fix(client): avoid toggling panel in extension inspect flow - #1126
Open
SidStraw wants to merge 1 commit into
Open
fix(client): avoid toggling panel in extension inspect flow#1126SidStraw wants to merge 1 commit into
SidStraw wants to merge 1 commit into
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
SidStraw
force-pushed
the
fix/1004-chrome-inspect-panel
branch
from
August 26, 2026 11:13
f022f75 to
8686d2b
Compare
The toggle-panel RPC minimizes the Vite overlay while inspecting a component, which only makes sense when the devtools UI lives on the page. Emitting it from browser extension panels (Chrome/Firefox) toggles the page's overlay unexpectedly (vuejs#1004). Skip the emit when running in an extension panel.
SidStraw
force-pushed
the
fix/1004-chrome-inspect-panel
branch
from
August 27, 2026 03:00
55ead8a to
c66ea1e
Compare
SidStraw
changed the title
SidStraw
marked this pull request as ready for review
August 27, 2026 03:50
cpatti97100
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using browser extension DevTools, starting the component inspector from the panel also toggles the Vite overlay panel on the page, so the two inspectors interfere with each other (#1004).
The client's component inspect handlers unconditionally emit the
toggle-panelRPC. That RPC exists to minimize the overlay while inspecting a component (#119), which only makes sense when the devtools UI lives on the page — not when triggered from a separate extension panel.This PR skips the emit when running in a browser extension panel, using the existing
isInChromePanelenv flag:fixes #1004
Validation
pnpm lintpnpm type-checkpnpm test(85/85)Recording.2026-08-26.at.18-48-56.mp4