Skip to content

fix: implement disableAppScope and disablePluginScope #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skirtles-code wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: implement disableAppScope and disablePluginScope #1044

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbe2c9e
fix: implement `disableAppScope` and `disablePluginScope`
skirtles-code Feb 14, 2026
8fb3f2d
Merge branch 'main' into app-specific-hooks
skirtles-code Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions packages/devtools-kit/src/api/v6/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,41 +20,60 @@ export class DevToolsV6PluginAPI {
return {
// component inspector
visitComponentTree: (handler: DevToolsV6PluginAPIHooks[DevToolsV6PluginAPIHookKeys.VISIT_COMPONENT_TREE]) => {
this.hooks.hook(DevToolsV6PluginAPIHookKeys.VISIT_COMPONENT_TREE, handler)
this.addHook(DevToolsV6PluginAPIHookKeys.VISIT_COMPONENT_TREE, handler)
},
inspectComponent: (handler: DevToolsV6PluginAPIHooks[DevToolsV6PluginAPIHookKeys.INSPECT_COMPONENT]) => {
this.hooks.hook(DevToolsV6PluginAPIHookKeys.INSPECT_COMPONENT, handler)
this.addHook(DevToolsV6PluginAPIHookKeys.INSPECT_COMPONENT, handler)
},
editComponentState: (handler: DevToolsV6PluginAPIHooks[DevToolsV6PluginAPIHookKeys.EDIT_COMPONENT_STATE]) => {
this.hooks.hook(DevToolsV6PluginAPIHookKeys.EDIT_COMPONENT_STATE, handler)
this.addHook(DevToolsV6PluginAPIHookKeys.EDIT_COMPONENT_STATE, handler)
},

// custom inspector
getInspectorTree: (handler: DevToolsV6PluginAPIHooks[DevToolsV6PluginAPIHookKeys.GET_INSPECTOR_TREE]) => {
this.hooks.hook(DevToolsV6PluginAPIHookKeys.GET_INSPECTOR_TREE, handler)
this.addHook(DevToolsV6PluginAPIHookKeys.GET_INSPECTOR_TREE, handler)
},
getInspectorState: (handler: DevToolsV6PluginAPIHooks[DevToolsV6PluginAPIHookKeys.GET_INSPECTOR_STATE]) => {
this.hooks.hook(DevToolsV6PluginAPIHookKeys.GET_INSPECTOR_STATE, handler)
this.addHook(DevToolsV6PluginAPIHookKeys.GET_INSPECTOR_STATE, handler)
},
editInspectorState: (handler: DevToolsV6PluginAPIHooks[DevToolsV6PluginAPIHookKeys.EDIT_INSPECTOR_STATE]) => {
this.hooks.hook(DevToolsV6PluginAPIHookKeys.EDIT_INSPECTOR_STATE, handler)
this.addHook(DevToolsV6PluginAPIHookKeys.EDIT_INSPECTOR_STATE, handler)
},

// timeline
inspectTimelineEvent: (handler: DevToolsV6PluginAPIHooks[DevToolsV6PluginAPIHookKeys.INSPECT_TIMELINE_EVENT]) => {
this.hooks.hook(DevToolsV6PluginAPIHookKeys.INSPECT_TIMELINE_EVENT, handler)
this.addHook(DevToolsV6PluginAPIHookKeys.INSPECT_TIMELINE_EVENT, handler)
},
timelineCleared: (handler: DevToolsV6PluginAPIHooks[DevToolsV6PluginAPIHookKeys.TIMELINE_CLEARED]) => {
this.hooks.hook(DevToolsV6PluginAPIHookKeys.TIMELINE_CLEARED, handler)
this.addHook(DevToolsV6PluginAPIHookKeys.TIMELINE_CLEARED, handler)
},

// settings
setPluginSettings: (handler: DevToolsV6PluginAPIHooks[DevToolsV6PluginAPIHookKeys.SET_PLUGIN_SETTINGS]) => {
this.hooks.hook(DevToolsV6PluginAPIHookKeys.SET_PLUGIN_SETTINGS, handler)
this.addHook(DevToolsV6PluginAPIHookKeys.SET_PLUGIN_SETTINGS, handler)
},
}
}

private addHook<H extends DevToolsV6PluginAPIHookKeys>(hook: H, handler: DevToolsV6PluginAPIHooks[H]) {
const wrapper: any = (...args: [any]) => {
const payload = args[0]
const { app, id, disableAppScope, disablePluginScope } = this.plugin.descriptor

if (!disableAppScope && payload.app != null && app !== payload.app) {
return
}

if (!disablePluginScope && payload.pluginId != null && id !== payload.pluginId) {
return
}

return handler(...args)
}

this.hooks.hook(hook, wrapper)
}

// component inspector
notifyComponentUpdate(instance?: ComponentInstance) {
if (devtoolsState.highPerfModeEnabled) {
Expand Down
Loading