Fix search-replica routing fairness and add VSCO 3.8.0 image publish workflow - #1
Open
ossianpe wants to merge 10 commits into
Open
Fix search-replica routing fairness and add VSCO 3.8.0 image publish workflow#1ossianpe wants to merge 10 commits into
ossianpe wants to merge 10 commits into
Conversation
…epth (opensearch-project#22557) (opensearch-project#22559) Two low-privilege search-request DoS vectors: - CVE-2026-63136 (regexp/query_string determinization OOM): max_determinized_states was read unbounded and passed to Lucene's RegexpQuery, so a request could set it to Integer.MAX_VALUE and disable Lucene's TooComplexToDeterminizeException safeguard. A pattern like .*a.{30} then determinizes toward ~2^30 states and exhausts the heap. - CVE-2026-63144 (simple_query_string nested-paren StackOverflow): Lucene's SimpleQueryParser recurses one frame per '(' with no depth cap, so deeply nested parentheses overflow the JVM stack. Both now fail fast with a 4xx instead of crashing the node. Adds regression tests including the reported PoC payloads. (cherry picked from commit f9cfc83) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Darshit Chanpura <dchanp@amazon.com>
…2579) (opensearch-project#22585) (cherry picked from commit f767a7a) Signed-off-by: Craig Perkins <craig5008@gmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com>
…pensearch-project#22591) (opensearch-project#22593) (cherry picked from commit 6056533) Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Andriy Redko <drreta@gmail.com>
…-project#22600) (cherry picked from commit 564ce01) Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Andriy Redko <drreta@gmail.com>
…arch-project#22606) (cherry picked from commit 46871ff) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
…oject#22612) (opensearch-project#22621) (cherry picked from commit 20ba4aa) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IndexShardRoutingTable.filterAndOrderShards: filter matching replicas first, then shuffle/order, so writer replicas no longer bias which search copy is preferred..github/workflows/vsco-publish-opensearch-image.yamlto build a non-snapshot patched:serverjar, validate it against upstream tag3.8.0, and swap it into the official multi-arch base image (avoids full recompile).3.8.0tag for the jar-swap safety check, build with-Dbuild.snapshot=false, and locate/verify the core jar by content rather than a hard-coded path.Test plan
IndexShardRoutingTableTests(esp. search-replica fairness / writer-ignored cases)vsco-publish-opensearch-image(or dry-run locally) and confirm a single non-SNAPSHOTopensearch-3.8.0.jaris found and containsIndexShardRoutingTablePlease note, the bulk of the files here are for getting helm operator releases working
Made with Cursor