Allow options in objectToDocumentXML when calling a method (take 2)#1509
Open
smokhov wants to merge 8 commits into
Open
Allow options in objectToDocumentXML when calling a method (take 2)#1509smokhov wants to merge 8 commits into
smokhov wants to merge 8 commits into
Conversation
* Options is optional field for objectToDocumentXML function * Replicates `_xml` parameter functionality (sending a custom XML structure as a literal) with JSON arguments.
smokhov
marked this pull request as ready for review
July 20, 2026 06:47
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reformats #1096 (by @ndeniche) using current prettier rules and fixes its test to do what it's supposed to do clearing an earlier objection here, so the test only passes if
overrideBaseElementistrue.