General maintenance, multiprocessing improvements, bug fixes in tests, move to tqdm#688
Open
IainHammond wants to merge 35 commits intovortex-exoplanet:masterfrom
Open
General maintenance, multiprocessing improvements, bug fixes in tests, move to tqdm#688IainHammond wants to merge 35 commits intovortex-exoplanet:masterfrom
IainHammond wants to merge 35 commits intovortex-exoplanet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes and improvements for this one:
multiprocessing.get_context()instead ofmultiprocessing.set_start_method()as it can be unsafe to set or change the start method multiple times, which can occur if several VIP functions are calledValueError: setting an array element with a sequencebeing raised in thefirstguessfunction due to changes in newer NumPy versionstqdmas default backend for progress bars sincepyrindis slower and not maintained anymorecube_inject_fakediskwhere the frame was convolved and then turned into an ADI cube, instead of the other way around (slower, but correct)For the future: