Prune dictionary layouts for missing list values#8778
Open
JSap0914 wants to merge 1 commit into
Open
Conversation
Signed-off-by: JSup <hanjisang0914@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Dictionary layouts currently return the input pruning mask for
list_contains, even when evaluating the expression against the dictionary values proves that no encoded row can match. This forces scans to fetch and evaluate the codes unnecessarily.Fixes #3953
What changes are included in this PR?
list_containsagainst the dictionary values during pruning.What APIs are changed? Are there any user-facing changes?
No public APIs change. Dictionary-backed scans can now skip code reads when membership is impossible.
Validation
cargo nextest run -p vortex-layout list_contains_pruning_uses_only_dictionary_valuescargo nextest run -p vortex-layout(134 passed)cargo clippy -p vortex-layout --all-targets --all-features -- -D warningscargo +nightly fmt -p vortex-layout -- --checkgit diff --checkAI assistance
This change was developed with agentic coding assistance and reviewed and tested by the contributor.