Share the Rust micro-benchmark workflow#8777
Merged
Merged
Conversation
connortsui20
force-pushed
the
ct/bench-declarative
branch
from
f3331ad to
80f1d97
Compare
Declare the two Rust micro-benchmark binaries in a small dedicated resolver and expose them through the existing matrix command. Replace the duplicated develop and PR jobs with one reusable workflow while preserving their mode-specific result handling. Keep this separate from the SQL profile migration so each change can be reviewed and landed independently. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
codex/bench-micro-workflow
branch
from
062fc95 to
51db3b2
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The develop and pull-request Rust micro-benchmark jobs duplicate the same setup, build, profiling, result, and failure-reporting logic. Keeping both copies aligned is error-prone, but folding this cleanup into the SQL matrix migration makes that PR harder to review.
This PR is therefore stacked on #8757 and contains only the Rust micro-benchmark follow-up.
What changes?
bench_orchestrator/benchmarks.py, alongside the SQL benchmark declarations.vx-bench matrix microwithout adding a generic selector or tag DSL.bench-core.yml.Commit structure
This is intentionally one commit: the two declarations and reusable workflow are one atomic change, since neither is useful without the other. The SQL registry and workflow migration remain independently reviewable in #8757.
Validation
uv run ruff check bench-orchestratoruv run ruff format --check bench-orchestratoruv run pytest bench-orchestrator/tests(25 passed; 6 matrix contract tests)basedpyrightonbenchmarks.pyandmatrix.pyyamllintandactionlinton the three affected workflows