Support reporting statistics and currently written byte size from writers in jni#8726
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
Expose currently written byte size to writers and through vortex-jni Signed-off-by: Robert Kruszewski <github@robertk.io>
Replace the top-level-only column size computation with a single walk of the layout tree that attributes each segment to the deepest field path referencing it, exposed as Footer::compressed_field_sizes. WriteSummary::compressed_column_sizes is now a thin schema-order wrapper over it. Signed-off-by: "Robert Kruszewski" <github@robertk.io> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JE2aKEzyogTh1dP126gudc
Construct the counting write before spawning the JNI write task and retrieve the shared counter directly via counter(), instead of threading a pre-allocated counter through with_counter. Sink creation now happens synchronously in NativeWriter.create, surfacing IO errors there instead of at close. Signed-off-by: "Robert Kruszewski" <github@robertk.io> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JE2aKEzyogTh1dP126gudc
robert3005
commented
Jul 14, 2026
robert3005
commented
Jul 15, 2026
AdamGS
approved these changes
Jul 15, 2026
robert3005
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to extract the whole file stats from the write instead of having to
read the files back