Fix tensor expressions and add InnerProduct expression#7277
Merged
connortsui20 merged 1 commit intodevelopfrom Apr 3, 2026
Merged
Fix tensor expressions and add InnerProduct expression#7277connortsui20 merged 1 commit intodevelopfrom
InnerProduct expression#7277connortsui20 merged 1 commit intodevelopfrom
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/inner-product
branch
from
8c80d34 to
b92e9f4
Compare
gatesn
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bunch of bugs and issues with tensor expressions (execution, validity handling) and adds an
InnerProductexpression.CosineSimilaritynow calls into bothInnerProductandL2Norm.Fun side change: adds
std::result::Result::andto the list of disallowed methods.API Changes
Adds some nice helpers for creating scalar fn expressions and arrays.
Testing
Some more tests, mainly making sure that validity is handled correctly now.