Scalar truncation is implemented over scalar values instead of scalars and can operate in place#6414
Merged
robert3005 merged 9 commits intodevelopfrom Feb 16, 2026
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
robert3005
force-pushed
the
rk/inplacetruncation
branch
from
2aaf10e to
4c5edf7
Compare
AdamGS
reviewed
Feb 11, 2026
robert3005
force-pushed
the
rk/inplacetruncation
branch
from
4c5edf7 to
17406b8
Compare
vortex-scalar/src/downcast.rs
Outdated
Comment on lines
203
to
208
| // pub fn as_extension(&self) -> &ExtScalarRef { | ||
| // match self { | ||
| // ScalarValue::Extension(e) => e, | ||
| // _ => vortex_panic!("ScalarValue is not an Extension"), | ||
| // } | ||
| // } |
robert3005
force-pushed
the
rk/inplacetruncation
branch
from
17406b8 to
6471d83
Compare
joseph-isaacs
approved these changes
Feb 16, 2026
…s and can operate in place Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
force-pushed
the
rk/inplacetruncation
branch
from
1fc96d7 to
dcae7e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a followup to the massive scalar refactor I have refactored the truncation logic to not require typed scalars. Since we now guarantee that values will be coerced to appropriate scalar value we can implement truncation logic over the underlying primitives
closes #6413