Skip to content

chore[ci]: don't build lance always #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joseph-isaacs wants to merge 1 commit into
base: develop
Choose a base branch
from
+8,426 −10
Draft

chore[ci]: don't build lance always #5957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
env:
RUSTFLAGS: "-C target-cpu=native -C force-frame-pointers=yes"
run: |
cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug --features lance
Copy link
Contributor

@AdamGS AdamGS Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the nightly flow where we do want to benchmark against lance right? if you remove it here, we're basically not benchmarking lance anywhere.

cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug

- name: Setup Polar Signals
uses: polarsignals/gh-actions-ps-profiling@v0.6.0
Expand All @@ -83,7 +83,7 @@ jobs:
env:
RUST_BACKTRACE: full
run: |
target/release_debug/${{ matrix.benchmark.id }} --formats parquet,lance,vortex -d gh-json -o results.json
target/release_debug/${{ matrix.benchmark.id }} --formats parquet,vortex -d gh-json -o results.json

- name: Setup AWS CLI
uses: aws-actions/configure-aws-credentials@v5
Expand All @@ -107,16 +107,14 @@ jobs:
"id": "clickbench-nvme",
"subcommand": "clickbench",
"name": "Clickbench on NVME",
"targets": "datafusion:parquet,datafusion:vortex,datafusion:vortex-compact,datafusion:lance,duckdb:parquet,duckdb:vortex,duckdb:vortex-compact,duckdb:duckdb",
Copy link
Contributor

@AdamGS AdamGS Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the point above

"build_lance": true
"targets": "datafusion:parquet,datafusion:vortex,datafusion:vortex-compact,duckdb:parquet,duckdb:vortex,duckdb:vortex-compact,duckdb:duckdb"
},
{
"id": "tpch-nvme",
"subcommand": "tpch",
"name": "TPC-H SF=1 on NVME",
"targets": "datafusion:arrow,datafusion:parquet,datafusion:vortex,datafusion:vortex-compact,datafusion:lance,duckdb:parquet,duckdb:vortex,duckdb:vortex-compact,duckdb:duckdb",
"scale_factor": "1.0",
"build_lance": true
"targets": "datafusion:arrow,datafusion:parquet,datafusion:vortex,datafusion:vortex-compact,duckdb:parquet,duckdb:vortex,duckdb:vortex-compact,duckdb:duckdb",
"scale_factor": "1.0"
},
{
"id": "tpch-s3",
Expand All @@ -131,9 +129,8 @@ jobs:
"id": "tpch-nvme-10",
"subcommand": "tpch",
"name": "TPC-H SF=10 on NVME",
"targets": "datafusion:arrow,datafusion:parquet,datafusion:vortex,datafusion:vortex-compact,datafusion:lance,duckdb:parquet,duckdb:vortex,duckdb:vortex-compact,duckdb:duckdb",
"scale_factor": "10.0",
"build_lance": true
"targets": "datafusion:arrow,datafusion:parquet,datafusion:vortex,datafusion:vortex-compact,duckdb:parquet,duckdb:vortex,duckdb:vortex-compact,duckdb:duckdb",
"scale_factor": "10.0"
},
{
"id": "tpch-s3-10",
Expand Down
40 changes: 40 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,46 @@ members = [
"xtask",
]
exclude = ["java/testfiles", "wasm-test"]
# lance-bench is excluded from default-members so it's not built by default.
# Build explicitly with: cargo build -p lance-bench
default-members = [
"vortex-bench",
"fuzz",
"vortex",
"vortex-array",
"vortex-btrblocks",
"vortex-buffer",
"vortex-compute",
"vortex-cxx",
"vortex-datafusion",
"vortex-dtype",
"vortex-duckdb",
"vortex-error",
"vortex-ffi",
"vortex-file",
"vortex-flatbuffers",
"vortex-cuda",
"vortex-io",
"vortex-ipc",
"vortex-jni",
"vortex-layout",
"vortex-mask",
"vortex-metrics",
"vortex-proto",
"vortex-python",
"vortex-scan",
"vortex-scalar",
"vortex-session",
"vortex-tui",
"vortex-utils",
"vortex-vector",
"benchmarks/compress-bench",
"benchmarks/datafusion-bench",
"benchmarks/duckdb-bench",
"benchmarks/random-access-bench",
"encodings/*",
"xtask",
]
resolver = "2"

[workspace.package]
Expand Down
Loading
Loading