Attempting to simplify the IO read traits #5935
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/io-simplification-experiment
branch
8 times, most recently
from
5b2562d to
344b500
Compare
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
AdamGS
force-pushed
the
adamg/io-simplification-experiment
branch
3 times, most recently
from
b53c46e to
a7a3b75
Compare
AdamGS
changed the title
AdamGS
commented
Jan 13, 2026
AdamGS
force-pushed
the
adamg/io-simplification-experiment
branch
from
a7a3b75 to
7400f87
Compare
AdamGS
force-pushed
the
adamg/io-simplification-experiment
branch
from
7400f87 to
a7e2722
Compare
danking
reviewed
Jan 13, 2026
|
|
||
| async move { req.resolve(Compat::new(read).await) } | ||
| }) | ||
| .map(move |f| self2.handle.spawn(f)) |
Contributor
There was a problem hiding this comment.
This is lost, right? I'm not entirely sure why we needed it, but the new drive implementation doesn't spawn the read future, right?
Contributor
Author
There was a problem hiding this comment.
Yeah I'm not convinced its necessary. reqwest already spawns some work, and object_store is tightly coupled with tokio and has its own abstraction (SpawnedReqwestConnector) for spawning work on a dedicated runtime.
danking
requested changes
Jan 13, 2026
Contributor
danking
left a comment
danking
left a comment
There was a problem hiding this comment.
Count me in for a single I/O source trait!
danking
approved these changes
Jan 13, 2026
Contributor
danking
left a comment
danking
left a comment
There was a problem hiding this comment.
They can revoke my approval privileges if they don't like my yolo approvals
|
|
||
| async move { req.resolve(Compat::new(read).await) } | ||
| }) | ||
| .map(move |f| self2.handle.spawn(f)) |
Comment on lines
+76
to
+57
| fn coalesce_config(&self) -> Option<CoalesceConfig> { | ||
| None | ||
| } |
Contributor
There was a problem hiding this comment.
I am interested why you think we should put this here. I would this the is a property of the underlying file system not the API to read from it. ebs vs local disk would be a good example.
Contributor
Author
There was a problem hiding this comment.
My assumption is that most systems will have their own VortexRead implementation for some adapter type (maybe we should provide some?) or some other custom type, and they can tune it to their expected hardware.
Contributor
There was a problem hiding this comment.
I see you want this method to be modified by an adapter. I wonder if it makes sense to move from out of the trait and use composition?
Contributor
Author
There was a problem hiding this comment.
More traits really increase the complexity IMO, I would really love to keep this in one trait.
AdamGS
force-pushed
the
adamg/io-simplification-experiment
branch
from
3cf35d9 to
678a26e
Compare
gatesn
requested changes
Jan 14, 2026
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
Give me some time to grok this..
AdamGS
force-pushed
the
adamg/io-simplification-experiment
branch
from
8b74a6b to
f14e9fa
Compare
Contributor
Author
|
After talking to @gatesn offline, I moved a lot of the file-specific logic from |
AdamGS
force-pushed
the
adamg/io-simplification-experiment
branch
3 times, most recently
from
b66d6c7 to
3b9a7ef
Compare
AdamGS
force-pushed
the
adamg/io-simplification-experiment
branch
from
d092cf7 to
fe6b759
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/io-simplification-experiment
branch
from
fe6b759 to
02875c7
Compare
Contributor
Author
|
Benchmarks results now seem fine, potentially some minor differences but everything seems to be much closer to the noise threshold. |
gatesn
reviewed
Jan 15, 2026
| /// different file systems and object stores so we encourage users to use this method | ||
| /// whenever possible and file issues if they encounter problems. | ||
| pub async fn open<S: IntoReadSource>(self, source: S) -> VortexResult<VortexFile> { | ||
| pub async fn open(self, source: Arc<dyn VortexReadAt>) -> VortexResult<VortexFile> { |
Contributor
There was a problem hiding this comment.
Are you sure you don't want open<R: TryInto<VortexReadAt>>(read: R) and open_read_at(Arc<dyn VortexReadAt>)?
Should help reduce the public API diff
Contributor
Author
There was a problem hiding this comment.
Its going to be a while before we release again, mind if I do it in a followup PR? There are a few things I want to try here but would love to merge this so I can move on to the python thing that came up.
Contributor
Author
There was a problem hiding this comment.
It also shouldn't be TryInto, if it has some issue getting started it'll just fail.
AdamGS
commented
Jan 15, 2026
| num_requests_coalesced: Arc<Histogram>, | ||
| } | ||
|
|
||
| impl StateMetrics { |
Contributor
Author
There was a problem hiding this comment.
this is a fly-by change, no need to keep reaching for the registry that's behind a lock on every request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have 3 traits (
IntoReadSource,ReadSourceandVortexReadAt), each implemented for different types, but with a large overlap between them. At least for me, it isn't obvious how to extend it for a custom type or how they are relate to each other.This PR is an attempt at trying to refactor the world of IO traits and types, in order to make it easier for users to provide their own specialized IO objects for observability/caching or any other reason.
I've tried to reduce the number of things a user needs to care and know about, ideally leaving us with a smaller API surface.