feat: add a method to push struct validity into children #5825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorynan
force-pushed
the
push_validity_into_children_for_struct_array
branch
from
2937655 to
5327203
Compare
Signed-off-by: amorynan <amorywang111@gmail.com>
This PR contains the following updates: | Package | Type | Update | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---|---|---| | [cc](https://redirect.github.com/rust-lang/cc-rs) | workspace.dependencies | patch | `1.2.49` -> `1.2.50` |  |  | | [cxx](https://cxx.rs) ([source](https://redirect.github.com/dtolnay/cxx)) | dependencies | patch | `1.0.191` -> `1.0.192` |  |  | | [cxx-build](https://cxx.rs) ([source](https://redirect.github.com/dtolnay/cxx)) | build-dependencies | patch | `1.0.191` -> `1.0.192` |  |  | | [moka](https://redirect.github.com/moka-rs/moka) | workspace.dependencies | patch | `0.12.11` -> `0.12.12` |  |  | | [reqwest](https://redirect.github.com/seanmonstar/reqwest) | workspace.dependencies | patch | `0.12.25` -> `0.12.26` |  |  | | [roaring](https://redirect.github.com/RoaringBitmap/roaring-rs) | workspace.dependencies | patch | `0.11.2` -> `0.11.3` |  |  | | [target-lexicon](https://redirect.github.com/bytecodealliance/target-lexicon) | workspace.dependencies | patch | `0.13.3` -> `0.13.4` |  |  | | com.google.protobuf | plugin | patch | `0.9.5` -> `0.9.6` |  |  | --- ### Release Notes <details> <summary>rust-lang/cc-rs (cc)</summary> ### [`v1.2.50`](https://redirect.github.com/rust-lang/cc-rs/blob/HEAD/CHANGELOG.md#1250---2025-12-19) [Compare Source](https://redirect.github.com/rust-lang/cc-rs/compare/cc-v1.2.49...cc-v1.2.50) ##### Other - Add tests for `OUT_DIR` escape for '..' file paths ([#​1631](https://redirect.github.com/rust-lang/cc-rs/issues/1631)) - Fix [#​283](https://redirect.github.com/rust-lang/cc-rs/issues/283): Make warnings(false) actually suppress compiler warnings ([#​1633](https://redirect.github.com/rust-lang/cc-rs/pull/1633)) </details> <details> <summary>dtolnay/cxx (cxx)</summary> ### [`v1.0.192`](https://redirect.github.com/dtolnay/cxx/releases/tag/1.0.192) [Compare Source](https://redirect.github.com/dtolnay/cxx/compare/1.0.191...1.0.192) - Add support for `Vec<Box<T>>` ([#​1681](https://redirect.github.com/dtolnay/cxx/issues/1681), thanks [@​anforowicz](https://redirect.github.com/anforowicz)) </details> <details> <summary>moka-rs/moka (moka)</summary> ### [`v0.12.12`](https://redirect.github.com/moka-rs/moka/blob/HEAD/CHANGELOG.md#Version-01212) [Compare Source](https://redirect.github.com/moka-rs/moka/compare/v0.12.11...v0.12.12) Bumped the minimum supported Rust version (MSRV) to 1.71.1, released on August 3, 2023 (\[[#​555](https://redirect.github.com/moka-rs/moka/issues/555)]\[gh-pull-0555]). ##### Fixed - Fixed use-after-free panic in the hierarchical timer wheels when `Expiry` returns `None` (\[[#​548](https://redirect.github.com/moka-rs/moka/issues/548)]\[gh-pull-0548], by \[[@​awarus](https://redirect.github.com/awarus)]\[gh-awarus]). - Fixed a subtle undefined behavior (UB) in the internal `deque::move_to_back` method (found by Miri) (\[[#​553](https://redirect.github.com/moka-rs/moka/issues/553)]\[gh-pull-0553]). ##### Added - `impl Expiry` for some types (\[[#​519](https://redirect.github.com/moka-rs/moka/issues/519)]\[gh-pull-0519], by \[[@​koushiro](https://redirect.github.com/koushiro)]\[gh-koushiro]). ##### Removed - Removed several unneeded files from the published package (\[[#​541](https://redirect.github.com/moka-rs/moka/issues/541)]\[gh-pull-0541], by \[[@​weiznich](https://redirect.github.com/weiznich)]\[gh-weiznich]). - Removed the `once_cell` crate from the dependencies (\[[#​520](https://redirect.github.com/moka-rs/moka/issues/520)]\[gh-pull-0520], by \[[@​Expyron](https://redirect.github.com/Expyron)]\[gh-Expyron]). - Removed the `rustc_version` crate from the dev-dependencies (\[[#​554](https://redirect.github.com/moka-rs/moka/issues/554)]\[gh-pull-0554]). </details> <details> <summary>seanmonstar/reqwest (reqwest)</summary> ### [`v0.12.26`](https://redirect.github.com/seanmonstar/reqwest/blob/HEAD/CHANGELOG.md#v01226) [Compare Source](https://redirect.github.com/seanmonstar/reqwest/compare/v0.12.25...v0.12.26) - Fix sending `Accept-Encoding` header only with values configured with reqwest, regardless of underlying tower-http config. </details> <details> <summary>RoaringBitmap/roaring-rs (roaring)</summary> ### [`v0.11.3`](https://redirect.github.com/RoaringBitmap/roaring-rs/releases/tag/v0.11.3) [Compare Source](https://redirect.github.com/RoaringBitmap/roaring-rs/compare/v0.11.2...v0.11.3) #### What's Changed - fix: bitmap advance\_back\_to could violate invariants by [@​Dr-Emann](https://redirect.github.com/Dr-Emann) in [#​339](https://redirect.github.com/RoaringBitmap/roaring-rs/pull/339) - Introduce Iter::next\_range and next\_range\_back by [@​Dr-Emann](https://redirect.github.com/Dr-Emann) in [#​338](https://redirect.github.com/RoaringBitmap/roaring-rs/pull/338) - Bump version to v0.11.3 and MSRV to 1.82 by [@​Kerollmops](https://redirect.github.com/Kerollmops) in [#​342](https://redirect.github.com/RoaringBitmap/roaring-rs/pull/342) **Full Changelog**: <RoaringBitmap/roaring-rs@v0.11.2...v0.11.3> </details> <details> <summary>bytecodealliance/target-lexicon (target-lexicon)</summary> ### [`v0.13.4`](https://redirect.github.com/bytecodealliance/target-lexicon/compare/v0.13.3...v0.13.4) [Compare Source](https://redirect.github.com/bytecodealliance/target-lexicon/compare/v0.13.3...v0.13.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/vortex-data/vortex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41OS4wIiwidXBkYXRlZEluVmVyIjoiNDIuNTkuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOlsiY2hvcmUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: amorynan <amorywang111@gmail.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | CodSpeedHQ/action | action | digest | `346a2d8` -> `972e343` | --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/vortex-data/vortex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41OS4wIiwidXBkYXRlZEluVmVyIjoiNDIuNTkuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOlsiY2hvcmUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: amorynan <amorywang111@gmail.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com> Signed-off-by: amorynan <amorywang111@gmail.com>
…inview (vortex-data#5814) I noticed that the better blocks compressor uses count_referenced_bytes which calls is_valid on each view and results in an expensive scalar_at call. This was 30% of our system-wide CPU usage over 12 hours (see PR for attached screenshot). This commit iterates over the nullability mask directly to avoid these expensive calls. <img width="1443" height="953" alt="image" src="https://github.com/user-attachments/assets/88a928d1-e223-426a-9c4e-bd5b35458a0d" /> Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com> Signed-off-by: amorynan <amorywang111@gmail.com>
…ta#5805) This change removes all the instances of `vortex_unwrap` and replaces them with `vortex_expect` essentially compelling the user to provide a justification of failure. Signed-off-by: Pratham Agarwal <agarwalpratham1812@gmail.com> Signed-off-by: amorynan <amorywang111@gmail.com>
This should also make sure that the fuzzer doesn't keep reporting the wrong error message. As for the TODO, see vortex-data#5820 Signed-off-by: Connor Tsui <connor.tsui20@gmail.com> Signed-off-by: amorynan <amorywang111@gmail.com>
This should fix the random access and compression failures on the commit to develop workflow Signed-off-by: Connor Tsui <connor.tsui20@gmail.com> Signed-off-by: amorynan <amorywang111@gmail.com>
amorynan
force-pushed
the
push_validity_into_children_for_struct_array
branch
from
5327203 to
4ba1a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ：
Enhanced the
StructArray::push_validity_into_childrenfunctionality with improved implementation and API convenience methods.And provides clear, self-documenting API
StructArray::push_validity_into_children_defaultfor default behavior Eliminates need to remember false parameter .