Skip to content

fix: resolve four code-scanning alerts - #148

Merged
lwwmanning merged 1 commit into
mainfrom
claude/code-scanning-fixes
Oct 30, 2026
Merged

lwwmanning merged 1 commit into
mainfrom
claude/code-scanning-fixes

Conversation

@lwwmanning

Copy link
Copy Markdown
Contributor

This PR fixes four code-scanning alerts.

  • CodeQL, two high alerts in bench's server smoke test. The regex that strips React's comment markers missed comments that span lines. One pass could also leave a <!-- behind. It now repeats until nothing changes. The test only reads our own HTML, so nothing was exposed.
  • Scorecard Token-Permissions. claude.yml now has top-level permissions: {}.
  • Scorecard Security-Policy. Adds SECURITY.md, which points to the Vortex project's policy.
  • Scorecard Vulnerabilities. Two 2020 advisories apply to an old npm package called sandbox. Vercel now publishes under that name, and the OSV records have no upper version bound. .github/vercel-cli/osv-scanner.toml ignores both and gives the reason.

🤖 Generated with Claude Code

- CodeQL js/bad-tag-filter and js/incomplete-multi-character-sanitization
  (high) on bench's server smoke test: the regex that strips React's
  comment markers missed comments that span lines, and one pass could
  leave a `<!--` that removing a comment created. Use [\s\S] and repeat
  until nothing changes. It only processes our own server's HTML in a
  test, so nothing was exposed.
- Scorecard Token-Permissions: claude.yml had no top-level permissions.
  Add `permissions: {}`; the job keeps the permissions it declares.
- Scorecard Security-Policy: add SECURITY.md. It sends reports to
  security@vortex.dev and points to the Vortex project's policy.
- Scorecard Vulnerabilities: GHSA-gc25-3vc5-2jf9 and GHSA-fm4j-4xhm-xpwx
  cover the npm package `sandbox` before 1.0.0, an unrelated 2011
  package whose name Vercel now publishes under. Their OSV records have
  no upper bound, so osv-scanner flags Vercel's sandbox 4.11.1 in the
  CLI's lockfile. .github/vercel-cli/osv-scanner.toml ignores both, with
  that reason; GitHub's advisory database scopes them to < 1.0.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Will Manning <will@willmanning.io>
@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
vortex Ready Ready Preview Oct 30, 2026 2:27am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T02:27:59.654471Z 111e1e4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

🔦 Lighthouse audit

URL Perf A11y Best practices SEO Report
/ 🟢 94 🟢 100 🟢 96 🟢 100 report
/blog 🟢 100 🟢 100 🟢 96 🟢 100 report
/blog/btrblocks-compressor 🟢 100 🟢 96 🟢 96 🟢 100 report

Run 40991734633 · 2026-10-30 02:28 UTC

@github-actions

Copy link
Copy Markdown

Bench preview for 111e1e4d52334338ca582b20d7c518082db46290: https://benchmarks-website-kkeircr0v-vortex-data.vercel.app

@lwwmanning
lwwmanning merged commit ab11ef0 into main Oct 30, 2026
20 checks passed
@lwwmanning
lwwmanning deleted the claude/code-scanning-fixes branch October 30, 2026 02:38
lwwmanning added a commit that referenced this pull request Oct 30, 2026
main runs Lighthouse on every PR as a required check (#147) and resolves
four code-scanning alerts (#148). The merge is clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Will Manning <will@willmanning.io>

This branch was successfully deployed

2 active deployments
bench-preview — 111e1e4d Deployed Oct 30, 2026 by lwwmanning via Bench: deploy #135
Preview — 111e1e4d Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant