Repository navigation
ci: run Lighthouse on every PR so it can be a required check - #147
Conversation
Lighthouse is the only check that asserts accessibility, SEO and best practices, but it filtered pull requests with paths-ignore, so it could not be required: a workflow that never starts leaves its check pending and blocks the merge. A changes job (the shared changed-paths action) now skips the audit when only bench changed; a skipped job reports success. A required check must not fail on one slow shared runner. Collect three runs per URL: LHCI asserts on the best run by default (aggregationMethod "optimistic"), so a real regression, which shows in every run, still fails, and an outlier run does not. The job timeout goes from 15 to 20 minutes for the extra runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 029d82a398
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🔦 Lighthouse audit
Run |
Fork PRs get a read-only GITHUB_TOKEN that can't post comments, and now that the audit runs on every PR and is to be required, a failed comment step would fail the check after a passing audit. Format and post the comment only for same-repository PRs. With three runs per URL, unique_by(.url) kept an arbitrary run, so the table could show a slow run the check didn't judge by. Show each URL's best run by performance, matching LHCI's optimistic assertions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48e7895950
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Dependabot's PRs come from this repository but get a read-only GITHUB_TOKEN, so the same-repository condition alone let the comment step try to write and fail the check with a 403. Skip Dependabot too, and make both comment steps non-fatal so no token limit can fail an audit that passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Lighthouse is the only check that tests accessibility, SEO and best practices, but it could not be a required check. It used
paths-ignore, so it never started on bench-only PRs, and a required check that never starts blocks the merge. Now it starts on every PR, and achangesjob skips the audit when only bench changed. A skipped job counts as passed.A required check must not fail because one shared runner is slow. Lighthouse now runs each URL three times and checks the best run. A real regression shows in every run and still fails. After this merges, I will add "Lighthouse audit" to the required checks on
main.🤖 Generated with Claude Code