Skip to content

fix: clear error banner when switching views#583

Merged
yaozheng-fang merged 2 commits into
volcengine:mainfrom
FirstayZheng:fix/error-banner-persist
Jun 5, 2026
Merged

fix: clear error banner when switching views#583
yaozheng-fang merged 2 commits into
volcengine:mainfrom
FirstayZheng:fix/error-banner-persist

Conversation

@FirstayZheng
Copy link
Copy Markdown
Contributor

@FirstayZheng FirstayZheng commented Jun 5, 2026

修复内容

修复错误提示框在切换视图后仍然显示的问题。

问题描述

当某个操作失败(如创建会话返回 403)时,页面顶部的错误提示框会持续显示,即使用户切换到其他视图(技能中心、智能搜索等)也不消失。

修复方案

在所有视图切换回调函数中添加 setError(""),确保切换视图时清理错误状态。

修改文件

  • frontend/src/App.tsx - 5 处视图切换回调添加错误清理
  • veadk/webui/ - 前端构建产物更新

测试验证

  • 触发错误提示后切换视图,错误提示正常消失
  • 新建会话、切换会话等功能正常
  • pre-commit 检查通过

zhengchuyi and others added 2 commits June 5, 2026 16:51
Error messages were persisting across view changes (e.g., switching
to Skill Center after a 403 error). Added setError("") to all view
switch callbacks (onSearch, onQuickCreate, onSkillCenter, onAddAgent,
onPickSession) to clear error state on navigation.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Rebuild frontend to resolve build artifact conflicts after rebasing onto upstream/main (commit 15c2b89).

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@FirstayZheng FirstayZheng force-pushed the fix/error-banner-persist branch from d959a77 to 3817439 Compare June 5, 2026 08:54
@yaozheng-fang yaozheng-fang merged commit a5eaea1 into volcengine:main Jun 5, 2026
3 checks passed
@FirstayZheng FirstayZheng deleted the fix/error-banner-persist branch June 5, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants