fix(sdk): convert structured message parts to request payloads - #3900
Open
rocke2020 wants to merge 2 commits into
Open
fix(sdk): convert structured message parts to request payloads#3900rocke2020 wants to merge 2 commits into
rocke2020 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fix preserves existing dict inputs while converting structured Part objects to the server wire shape.
image_urlpayload.Fixes #3890
Verification
The exact issue input now reaches the mocked transport as valid JSON, including mixed text, image, and tool parts.
.venv/bin/ruff check ...— passed.text,image_url,toolparts.uv build --wheel sdk/python— built one wheel;uv.lockunchanged.The deselected
test_glob_normalizes_scope_uriis an existing upstream expectation mismatch: current upstream code sends the defaultnode_limit=256, while that upstream test still expects nonode_limit. This PR does not change that path.