Repository navigation
fix(deploy): honor cloudflare.assets.html_handling on static CF deploy - #588
Merged
Merged
Conversation
Fixes voidzero-dev#580 ## Summary Static `void deploy --platform cloudflare` always wrote `assets.html_handling: auto-trailing-slash` into the generated `wrangler-static.json`, ignoring `cloudflare.assets.html_handling` from `void.config.ts` / the materialized root Wrangler config. That caused extra 307 redirects for prerendered sites using `about/index.html` with links to `/about`. ## Changes - Read `assets.html_handling` from the root Wrangler config at static deploy time. - Pass it through `buildStaticManifest` into `manifest.assetConfig` so `writeCloudflareStaticDeployConfig` persists the authored value. - Type `cloudflare.assets.html_handling` in Void config as `AssetConfig['html_handling']` from `@void/deploy-core` (no duplicated union). ## Testing - `packages/void/test/unit/package.test.ts` (manifest + wrangler reader) - `packages/deploy-cloudflare/test/unit/static.test.ts` (config writer) - `packages/void/test/unit/cloudflare-deploy.test.ts` (end-to-end static deploy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #580
Summary
Static
void deploy --platform cloudflarealways wroteassets.html_handling: auto-trailing-slashinto the generatedwrangler-static.json, ignoringcloudflare.assets.html_handlingfromvoid.config.ts/ the materialized root Wrangler config. That caused extra 307 redirects for prerendered sites usingabout/index.htmlwith links to/about.Changes
assets.html_handlingfrom the root Wrangler config at static deploy time.buildStaticManifestintomanifest.assetConfigsowriteCloudflareStaticDeployConfigpersists the authored value.cloudflare.assets.html_handlingin Void config asAssetConfig['html_handling']from@void/deploy-core(no duplicated union).Testing
packages/void/test/unit/package.test.ts(manifest + wrangler reader)packages/deploy-cloudflare/test/unit/static.test.ts(config writer)packages/void/test/unit/cloudflare-deploy.test.ts(end-to-end static deploy)