-
Notifications
You must be signed in to change notification settings - Fork 14
feat: --concurrency-limit and --parallel
#309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
branchseer
wants to merge
13
commits into
main
Choose a base branch
from
feat/concurrency-parallel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,063
−3,298
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ec3bcfb
feat: add --concurrency and --parallel flags
branchseer 7666108
docs: update changelog with PR links for --concurrency and --parallel
branchseer 699176d
docs: simplify changelog wording
branchseer 59cb4be
refactor: rename --concurrency to --concurrency-limit, default to 4
branchseer 259588f
fix: remove broken CONCURRENCY_LIMIT doc link
branchseer f5ae5a9
docs: add concurrency documentation
branchseer a471fa6
docs: fix flag ordering in concurrency examples
branchseer 7b35c53
docs: add design rationale to concurrency documentation
branchseer f22f8f0
refactor: replace concurrency inheritance with VP_RUN_CONCURRENCY_LIM…
branchseer 4f68003
fix: guard interactive selector against execution flags, cap semaphore
branchseer 7c255fb
update docs
branchseer e9f8d0f
fix: correct concurrency resolution order in docs and comments
branchseer 7735322
test(e2e): add --parallel flag execution test
branchseer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
crates/vite_task_bin/tests/e2e_snapshots/fixtures/parallel-execution/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "name": "parallel-execution-test", | ||
| "private": true | ||
| } |
6 changes: 6 additions & 0 deletions
6
crates/vite_task_bin/tests/e2e_snapshots/fixtures/parallel-execution/packages/a/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "name": "@parallel/a", | ||
| "scripts": { | ||
| "build": "vtt barrier ../../.barrier sync 2" | ||
| } | ||
| } |
9 changes: 9 additions & 0 deletions
9
crates/vite_task_bin/tests/e2e_snapshots/fixtures/parallel-execution/packages/b/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "name": "@parallel/b", | ||
| "scripts": { | ||
| "build": "vtt barrier ../../.barrier sync 2" | ||
| }, | ||
| "dependencies": { | ||
| "@parallel/a": "workspace:*" | ||
| } | ||
| } |
2 changes: 2 additions & 0 deletions
2
crates/vite_task_bin/tests/e2e_snapshots/fixtures/parallel-execution/pnpm-workspace.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| packages: | ||
| - packages/* |
8 changes: 8 additions & 0 deletions
8
crates/vite_task_bin/tests/e2e_snapshots/fixtures/parallel-execution/snapshots.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Package b depends on a, so without --parallel they run sequentially. | ||
| # Both use a barrier requiring 2 participants — if run sequentially the | ||
| # first would wait forever and the test would timeout. | ||
| # --parallel discards dependency edges, allowing both to run at once. | ||
|
|
||
| [[e2e]] | ||
| name = "parallel flag runs dependent tasks concurrently" | ||
| steps = [["vt", "run", "-r", "--parallel", "build"]] |
11 changes: 11 additions & 0 deletions
11
...ixtures/parallel-execution/snapshots/parallel flag runs dependent tasks concurrently.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| source: crates/vite_task_bin/tests/e2e_snapshots/main.rs | ||
| expression: e2e_outputs | ||
| --- | ||
| > vt run -r --parallel build | ||
| ~/packages/a$ vtt barrier ../../.barrier sync 2 ⊘ cache disabled | ||
| ~/packages/b$ vtt barrier ../../.barrier sync 2 ⊘ cache disabled | ||
|
|
||
|
|
||
| --- | ||
| vt run: 0/2 cache hit (0%). (Run `vt run --last-details` for full details) |
3 changes: 3 additions & 0 deletions
3
crates/vite_task_bin/tests/e2e_snapshots/fixtures/parallel-execution/vite-task.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "cache": false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.