feat: add VP_* to DEFAULT_UNTRACKED_ENV#297
Merged
fengmk2 merged 1 commit intovoidzero-dev:mainfrom Mar 26, 2026
Merged
Conversation
jong-kyung
force-pushed
the
refactor/add-vp-to-default-untracked-env
branch
from
558de2f to
cc66d1a
Compare
branchseer
approved these changes
Mar 26, 2026
fengmk2
approved these changes
Mar 26, 2026
This was referenced Mar 26, 2026
fengmk2
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Mar 27, 2026
## Summary - Bump vite-task git dependency from `2663222` to `26c1892` (includes [voidzero-dev/vite-task#297](voidzero-dev/vite-task#297)) - Add `tokio-util` dependency and pass `CancellationToken` to `fspy::Command::spawn()` to adapt to the updated API Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
fengmk2
pushed a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Mar 29, 2026
## Summary Closes #1074 Rename all internal `VITE_PLUS_*` environment variables to `VP_*` prefix to avoid Vite's default `envPrefix: "VITE_"` from exposing them in bundled applications via `import.meta.env`. - Rename 25 env vars across Rust, TypeScript, shell scripts, CI workflows, and snap tests - Rename Rust constant identifiers and `get_vite_plus_home()` → `get_vp_home()` to match - Update all code comments and user-facing docs (`docs/guide/env.md`) - Env vars **not** renamed: `VITE_LOG`, `VITE_NODE_DIST_MIRROR`, `VITE_UPDATE_TASK_TYPES`, `VITE_GLOBAL_CLI_JS_SCRIPTS_DIR` — these use the `VITE_` prefix (not `VITE_PLUS_`) and are intentionally kept ### Prerequisite (merged) - vite-task: [voidzero-dev/vite-task#297](voidzero-dev/vite-task#297) — Add `VP_*` to `DEFAULT_UNTRACKED_ENV` so internal vars pass through to child processes without affecting cache keys
otoneko1102
pushed a commit
to otoneko1102/viteplus-ja
that referenced
this pull request
Mar 30, 2026
## Summary Closes #1074 Rename all internal `VITE_PLUS_*` environment variables to `VP_*` prefix to avoid Vite's default `envPrefix: "VITE_"` from exposing them in bundled applications via `import.meta.env`. - Rename 25 env vars across Rust, TypeScript, shell scripts, CI workflows, and snap tests - Rename Rust constant identifiers and `get_vite_plus_home()` → `get_vp_home()` to match - Update all code comments and user-facing docs (`docs/guide/env.md`) - Env vars **not** renamed: `VITE_LOG`, `VITE_NODE_DIST_MIRROR`, `VITE_UPDATE_TASK_TYPES`, `VITE_GLOBAL_CLI_JS_SCRIPTS_DIR` — these use the `VITE_` prefix (not `VITE_PLUS_`) and are intentionally kept ### Prerequisite (merged) - vite-task: [voidzero-dev/vite-task#297](voidzero-dev/vite-task#297) — Add `VP_*` to `DEFAULT_UNTRACKED_ENV` so internal vars pass through to child processes without affecting cache keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VP_*pattern toDEFAULT_UNTRACKED_ENVso that Vite+ internal environment variables (e.g.VP_HOME,VP_VERSION) are passed through to child processes without affecting cache keys.Context
This is a prerequisite for voidzero-dev/vite-plus#1074, which renames all
VITE_PLUS_*env vars toVP_*to avoid leaking internal vars through Vite'senvPrefix(defaultVITE_).After the rename,
VP_*vars no longer match theVITE_*fingerprinted env pattern set byvp build. Without this change,VP_VERSION(and other internal state vars) would be filtered out byEnvFingerprints::resolve()and not reach child processes.VP_*belongs inuntracked_env(notfingerprinted_envs) because these are internal runtime state variables that should not affect cache keys.