Skip to content

test(cli): reproduce stdio backpressure#2172

Open
wan9chi wants to merge 1 commit into
mainfrom
agent/test-stdio-backpressure-e2e
Open

test(cli): reproduce stdio backpressure#2172
wan9chi wants to merge 1 commit into
mainfrom
agent/test-stdio-backpressure-e2e

Conversation

@wan9chi

@wan9chi wan9chi commented Jul 14, 2026

Copy link
Copy Markdown
Member

Motivation

Reproduces #2165, so the fix in #2173 can be verified.

How

  • add a Unix-only vpt backpressure-run payload that gives a child a non-blocking socket-backed stdout
  • keep the channel pressurized by reading one small chunk only when it is full, allowing blocking output to progress while detecting a full O_NONBLOCK writer directly
  • add a vp check fixture with 128 deterministic lint warnings, exercised through both local and global CLI flavors
  • record the current broken behavior with a stable backpressure-run detected truncated child output under stdio backpressure diagnostic

CI behavior

The failing command behavior is the expected snapshot in this layer, so the regression is visible without making this PR's CI red. The next PR in the stack changes the same snapshots to the complete successful output.

@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 1bfedce
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a56fbff3ffc590008f7a8c8

wan9chi commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Native binary sizes (1bfedce)

Final release artifacts built by the canonical build-upstream and build-windows-cli actions.

Artifact Format Base PR Change
vp (Linux x64) Binary 10.32 MiB 10.32 MiB 0 B (0.00%)
vp (Linux x64) gzip -9 4.42 MiB 4.42 MiB 0 B (0.00%)
NAPI (Linux x64) Binary 33.42 MiB 33.42 MiB 0 B (0.00%)
NAPI (Linux x64) gzip -9 12.78 MiB 12.78 MiB 0 B (0.00%)
vp (macOS ARM64) Binary 7.64 MiB 7.64 MiB 0 B (0.00%)
vp (macOS ARM64) gzip -9 3.83 MiB 3.83 MiB 0 B (0.00%)
NAPI (macOS ARM64) Binary 40.78 MiB 40.78 MiB 0 B (0.00%)
NAPI (macOS ARM64) gzip -9 17.05 MiB 17.05 MiB -2 B (-0.00%)
vp (Windows x64) Binary 8.37 MiB 8.37 MiB 0 B (0.00%)
vp (Windows x64) gzip -9 3.64 MiB 3.64 MiB -1 B (-0.00%)
NAPI (Windows x64) Binary 27.88 MiB 27.88 MiB 0 B (0.00%)
NAPI (Windows x64) gzip -9 10.78 MiB 10.78 MiB +1 B (+0.00%)
Trampoline (Windows x64) Binary 203.00 KiB 203.00 KiB 0 B (0.00%)
Trampoline (Windows x64) gzip -9 97.91 KiB 97.91 KiB +2 B (+0.00%)
Installer (Windows x64) Binary 4.46 MiB 4.46 MiB 0 B (0.00%)
Installer (Windows x64) gzip -9 2.08 MiB 2.08 MiB +1 B (+0.00%)

@wan9chi wan9chi force-pushed the agent/test-stdio-backpressure-e2e branch from aaa12f4 to 4bdb273 Compare July 14, 2026 12:33
@wan9chi wan9chi marked this pull request as ready for review July 15, 2026 02:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bdb2733bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_cli_snapshots/src/bin/vpt/backpressure_run.rs Outdated
@wan9chi wan9chi force-pushed the agent/test-stdio-backpressure-e2e branch from 4bdb273 to 1bfedce Compare July 15, 2026 03:18
@wan9chi wan9chi marked this pull request as draft July 15, 2026 03:18
@wan9chi wan9chi marked this pull request as ready for review July 15, 2026 04:02
@wan9chi wan9chi requested review from Brooooooklyn and cpojer July 15, 2026 04:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bfedcee12

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_cli_snapshots/src/bin/vpt/backpressure_run.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants