ci(create): assert the monorepo library emits declarations#2171
Open
wan9chi wants to merge 1 commit into
Open
Conversation
A green `vp run ready` proves the build exited 0, but declaration generation can degrade silently (skipped generator, wrong output location) while the exit code stays clean. Pin the deliverable: after the build, packages/utils/dist/index.d.mts must exist. With the monorepo template now scaffolding TypeScript 7 (#2168), this makes the create jobs an end-to-end regression gate for the native compiler (tsgo) dts path that broke in #2160. Verified against a real local-registry build: `vp pack` emits dist/index.d.mts (not .d.ts) next to the ESM bundle. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for viteplus-preview canceled.
|
wan9chi
added
test: e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a declaration-output assertion to the
vp create monorepoCI jobs: aftervp run ready,packages/utils/dist/index.d.mtsmust exist.Why
A green
vp run readyonly proves the build exited 0. Declaration generation can degrade silently — generator skipped, output landing in the wrong place — while the exit code stays clean, which would ship type-less libraries from every freshly created monorepo without CI noticing.Since #2168 the monorepo template scaffolds TypeScript 7, so the utils library's
vp packruns dts through tsdown's native-compiler (tsgo) path — the machinery that broke in #2160. This assertion turns the four create jobs into an end-to-end regression gate for that path across pnpm/npm/yarn/bun.Notes
index.d.mts(paired with the ESMindex.mjsbundle), notindex.d.ts— verified against a local-registry build of main:🤖 Generated with Claude Code