feat(cli): add JetBrains editor setup#2122
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
db9754e to
4016f35
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4016f35 to
ab14ae6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab14ae6767
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: 'jetbrains', | ||
| label: 'JetBrains', | ||
| aliases: ['intellij'], | ||
| targetDir: '.idea', |
There was a problem hiding this comment.
Unignore JetBrains config before relying on it
When vp create ... --editor jetbrains writes externalDependencies.xml under .idea, the generated monorepo template still ignores .idea (packages/cli/templates/monorepo/_gitignore:24), and the create flow only unignores VS Code configs (packages/cli/src/create/bin.ts:1105-1106 and 1273-1274). In that generated-project context the required plugin file is ignored, so a normal initial commit omits the JetBrains setup even though the CLI reported writing it; add a JetBrains-specific unignore step similar to the VS Code one.
Useful? React with 👍 / 👎.
Fixes #1987
Summary
intellijas an alias..idea/externalDependencies.xmlwith the Oxc IntelliJ plugin as a required plugin.Verification
pnpm exec tsc -p /private/tmp/vite-plus-editor-tsconfig.jsonpnpm exec oxfmt --config /private/tmp/oxfmt-single-semi.json --check packages/cli/src/utils/editor.ts packages/cli/src/utils/__tests__/editor.spec.tsgit diff --checkpnpm -C packages/cli test src/utils/__tests__/editor.spec.tscould not start in this local checkout because building the requiredrolldownnative binding needscargo, which is not available in this environment.Disclosure
This contribution was prepared with AI assistance and reviewed before submission.