fix: stop intercepting vite as a vp command in task scripts#1186
Draft
fengmk2 wants to merge 2 commits intovp-run-no-fallbackfrom
Draft
fix: stop intercepting vite as a vp command in task scripts#1186fengmk2 wants to merge 2 commits intovp-run-no-fallbackfrom
vite as a vp command in task scripts#1186fengmk2 wants to merge 2 commits intovp-run-no-fallbackfrom
Conversation
This was referenced Mar 28, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
vp-run-no-fallback
branch
from
3af4839 to
3048c0d
Compare
fengmk2
force-pushed
the
vp-run-no-fallback
branch
from
3048c0d to
ad0a0c7
Compare
graphite-app
bot
force-pushed
the
vp-run-no-fallback
branch
from
ad0a0c7 to
6c24f5a
Compare
`VitePlusCommandHandler` was intercepting both `vp` and `vite` program names in task scripts. This caused `vp run dev` to fail with "Invalid vite task command" when a package.json script used bare `vite` (e.g. `"dev": "vite"`), because `vite` is a separate tool, not a vp alias. Only intercept `vp` commands now; `vite` runs verbatim as an external process. Closes #1176
graphite-app
bot
force-pushed
the
fix-issue-1176
branch
from
3fcad86 to
756e54f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VitePlusCommandHandlerwas intercepting bothvpandviteprogramnames in task scripts. This caused
vp run devto fail with "Invalidvite task command" when a package.json script used bare
vite(e.g."dev": "vite"), becauseviteis a separate tool, not a vp alias.Only intercept
vpcommands now;viteruns verbatim as an externalprocess.
Closes #1176