Skip to content

fix: correctly inform about prettierignore #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 2 commits into from
Mar 27, 2026
+2 −2
Merged

fix: correctly inform about prettierignore #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f4eb4
fix: correctly inform about prettierignore
TheAlexLichter Mar 26, 2026
371398d
fmt
TheAlexLichter Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/migration/migrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ export async function migratePrettierToOxfmt(
const prettierIgnorePath = path.join(projectPath, '.prettierignore');
if (fs.existsSync(prettierIgnorePath)) {
warnMigration(
`${displayRelative(prettierIgnorePath)} found — Oxfmt uses .oxfmtignore. Please migrate manually.`,
`${displayRelative(prettierIgnorePath)} found — Oxfmt supports .prettierignore, but using the \`ignorePatterns\` option is recommended.`,
options?.report,
);
}
Expand Down
2 changes: 1 addition & 1 deletion rfcs/migration-command.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ When a Prettier configuration file (`.prettierrc*`, `prettier.config.*`, or `"pr
4. Remove `prettier` and `prettier-plugin-*` from `devDependencies`/`dependencies`
5. Rewrite `prettier` scripts in `package.json` to `vp fmt`, stripping Prettier-only flags
6. Rewrite `prettier` references in lint-staged configs
7. Warn about `.prettierignore` if present (Oxfmt uses `.oxfmtignore`)
7. Warn about `.prettierignore` if present (Oxfmt supports it, but `ignorePatterns` is recommended)
8. The existing migration flow picks up `.oxfmtrc.json` and merges it into `vite.config.ts`

**Script Rewriting** (powered by [brush-parser](https://github.com/reubeno/brush) for shell AST parsing):
Expand Down
Loading