feat(dev): simplify local dev workflow#1102
Open
Salnika wants to merge 4 commits intovoidzero-dev:mainfrom
Open
feat(dev): simplify local dev workflow#1102Salnika wants to merge 4 commits intovoidzero-dev:mainfrom
Salnika wants to merge 4 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
|
@Salnika Thanks, look good. I will take a try before merge. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the repo’s local CLI development workflow by introducing repo-local install/bootstrap scripts, building/using local CLI artifacts by default, and isolating snap tests from ~/.vite-plus state.
Changes:
- Added
pnpm install:dev/pnpm bootstrap:devflows to prepare upstream checkouts, install deps, and build the local CLI. - Switched tests and global snap tests to use repo-local artifacts (including a temp
VITE_PLUS_HOME) instead of~/.vite-plus. - Updated
just initand contributor docs to reflect the new local-dev-first workflow.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/setup-local-dev.mjs | New repo-local setup script that clones/syncs upstream checkouts and runs pnpm install. |
| pnpm-lock.yaml | Adds workspace link resolution for rolldown (lockfile update). |
| packages/tools/src/snap-test.ts | Uses a temp VITE_PLUS_HOME under the test temp dir for stability and isolation. |
| packages/tools/src/local-cli.ts | New tooling entrypoints for building and running repo-local CLI + local global snap tests. |
| packages/tools/src/index.ts | Registers new tool subcommands (build-local-cli, local-cli, snap-test-global-local). |
| packages/prompts/package.json | Adds rolldown as a devDependency (workspace). |
| packages/cli/package.json | Routes test and global snap tests through the repo-local tool entrypoints. |
| package.json | Adds install:dev, bootstrap:dev, build:cli, and updates test/bootstrap scripts to use local flow. |
| justfile | Updates just init to delegate to pnpm install:dev. |
| CONTRIBUTING.md | Documents the new local CLI workflow and updated initialization guidance. |
| CLAUDE.md | Updates build/snap-test guidance to emphasize repo-local artifacts. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
63da70a to
1e6dba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies local development of the CLI.
It adds a repo-local setup and bootstrap flow so a fresh clone can be prepared with:
It also keeps
bootstrap-clifor the global install flow.What changed
pnpm install:devto prepare local upstream checkouts and install dependenciespnpm bootstrap:devto prepare the repo and build the local CLI~/.vite-plusjust initand contributor docs to reflect the new workflowWhy
The local development workflow required extra manual setup before the CLI could be built and tested.
This PR makes the common development path more direct while keeping the existing global install flow available.