Repository navigation
Conversation
…outside components Directive, pipe, injectable and NgModule factories took `attributeNameType` from the parameter's type, which is unset for `string`, so the attribute name was injected as a DI token. Use the attribute name literal like ngtsc's di.ts. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #624.
Problem
For
@Directive,@Pipe,@Injectableand@NgModule, the constructor param extractors setattribute_name_typeto the parameter's type token. For@Attribute('title') t: stringthat isNone, socompile_inject_dependencyemittedɵɵdirectiveInject("title")/ɵɵinject("title")and Angular resolved"title"as a DI token (NullInjectorError: No provider for title!). Components were unaffected because they use a separate dependency path.Fix
Set
attribute_name_typeto the attribute name literal in the four extractors, as ngtsc does inngtsc/annotations/common/src/di.ts(attributeNameType = new LiteralExpr(attributeName.text)).compileInjectDependencyinrender3/r3_factory.tsthen emitsɵɵinjectAttributewhatever the target. As a side effect, string-typed@Attributeparams now also getattribute: truein partial declarations and anattributeentry in the.d.tsctor deps type, which they were missing.Checks
tests/attribute_inject_test.rs:directive_factory_injects_the_attribute,pipe_factory_injects_the_attribute,injectable_factory_injects_the_attribute,ng_module_factory_injects_the_attribute(all fail onmain).cargo test -p oxc_angular_compiler --all-features: 3520 passed, 0 failed.🤖 Generated with Claude Code