feat: add attribute, input, and output visitor methods to R3Visitor#180
Open
Shinigami92 wants to merge 2 commits intovoidzero-dev:mainfrom
Open
feat: add attribute, input, and output visitor methods to R3Visitor#180Shinigami92 wants to merge 2 commits intovoidzero-dev:mainfrom
Shinigami92 wants to merge 2 commits intovoidzero-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
visit_text_attribute,visit_bound_attribute, andvisit_bound_eventmethods to theR3Visitortrait, and updates the default traversal for elements, templates, components, and content nodes to call them.Previously,
visit_element_childrenandvisit_template_childrenonly traversed child nodes, skipping overattributes,inputs, andoutputs. This made it impossible to use the visitor pattern to inspect bindings and events without overriding the element visitor and manually iterating those fields.This is a non-breaking change — all new methods have default no-op implementations, so existing
R3Visitorimplementations continue to work unchanged.Motivation: enables using
R3Visitorfor template linting use cases, where rules need to inspect attributes and bindings (e.g. checking for[property]bindings,(event)handlers, or static attribute values).