Repository navigation
Conversation
swayimg reads EXIF through exiv2 (meson option 'exif'), not libexif, so the package was built without EXIF: images were not rotated by their EXIF orientation and the EXIF fields of the info overlay were empty. Enable the feature explicitly so a missing exiv2 fails the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Maintainer ping @voidbert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swayimg reads EXIF through exiv2 (
meson.build:dependency('exiv2', required: get_option('exif'))), but the template listslibexif-devel, so theautofeature finds nothing and the package is built without EXIF:ldd /usr/bin/swayimgshows nolibexiv2, portrait photos from a camera are shown sideways even withswayimg.exif_orientation = true, and the{meta.Exif.*}fields of the text overlay are empty.This replaces
libexif-develwithexiv2-develand sets-D exif=enabled, so a missing exiv2 fails the build instead of silently dropping EXIF again.Testing the changes
Rotate 270 CW) are upright in the viewer and in the gallery; the binary linkslibexiv2.so.28.Local build testing
The change was prepared with an AI assistant (Claude) and built and tested by me.
🤖 Generated with Claude Code