Skip to content

New package: ledger-autosync-1.2.0 - #62349

Merged
Vaelatern merged 4 commits into
void-linux:masterfrom
nazaradeh:new-package-ledger-autosync-1.2.0
Sep 3, 2026
Merged

New package: ledger-autosync-1.2.0#62349
Vaelatern merged 4 commits into
void-linux:masterfrom
nazaradeh:new-package-ledger-autosync-1.2.0

Conversation

@nazaradeh

@nazaradeh nazaradeh commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES
  • Tested by creating a test .ofx file and running the program with it.

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l

Notes

  • Closes Ledger autosync #24756. @Vaelatern, the author of that PR, has requested I open up a new PR with my review, so please do not close this PR as a duplicate.
  • @Vaelatern if you'd like me to put you down as the maintainer for these, let me know. Either way, seems like a stable program that hasn't had/needed an update in years.
  • Other than this PR being for a newer version than the old PR, I also patched out
    argparse instead of doing a do_check workaround.

@nazaradeh
nazaradeh marked this pull request as draft September 2, 2026 17:43
@nazaradeh
nazaradeh force-pushed the new-package-ledger-autosync-1.2.0 branch from f3e483b to 4f00f71 Compare September 2, 2026 17:45
@nazaradeh
nazaradeh marked this pull request as ready for review September 2, 2026 17:45
@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Sep 2, 2026
@Vaelatern

Copy link
Copy Markdown
Member

Only adjustment is to split into 4 packages

@nazaradeh

Copy link
Copy Markdown
Contributor Author

Only adjustment is to split into 4 packages

Meaning four different PRs? I would think because it's four separate templates that it counts as 4 packages. Looking at how other people do PRs with multiple packages, I don't know what's different. Let me know!

@Vaelatern

Copy link
Copy Markdown
Member

One PR, one git branch, but 4 commits between master and new-package-ledger-autosync-1.2.0

@Vaelatern

Copy link
Copy Markdown
Member

So fun fact you can "rewrite history" to do this, then force pushing to have the work on the branch. You don't even need your local and remote branches to have the same name, if you don't want to (or it's easier that way).

@nazaradeh
nazaradeh force-pushed the new-package-ledger-autosync-1.2.0 branch from 4f00f71 to 56b424b Compare September 3, 2026 04:22
@nazaradeh

Copy link
Copy Markdown
Contributor Author

Ahh gotcha, right yes once it gets merged in you just see the commits on main. Thanks! I'm used to perforce for work but not git outside of personal projects so still learning.

Should be good now, then, after CI passes.

@Vaelatern
Vaelatern merged commit 957e988 into void-linux:master Sep 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-package This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants