This repository was archived by the owner on Mar 6, 2024. It is now read-only.
Add UI extensions commands#245
Open
nvladimirovi wants to merge 1 commit intovmware-archive:masterfrom
Open
Conversation
nvladimirovi
force-pushed
the
extensions
branch
7 times, most recently
from
6f55d31 to
43a01e5
Compare
Contributor
|
vcd-cli project is not the right place to craft REST requests or write business logic, pyvcloud is the right place to craft REST reuqest and process the responses. I think this PR needs to be split into two PRs one on pyvcloud dealing with REST + business logic and another one in this project dealing with just the cli aspect of the commands. |
nvladimirovi
force-pushed
the
extensions
branch
from
43a01e5 to
3212c31
Compare
Author
|
Thank you for your comment, I moved the UiPlugin class to pyvcloud project, but ExtGenerator class has to stay in vcd-cli because this class depends on other classes, which are related to the CLI functionality. |
nvladimirovi
force-pushed
the
extensions
branch
4 times, most recently
from
475741a to
da66cd1
Compare
nvladimirovi
force-pushed
the
extensions
branch
from
da66cd1 to
ef459be
Compare
nvladimirovi
force-pushed
the
extensions
branch
3 times, most recently
from
b67df4c to
9269fa4
Compare
Following commads are added: generate, list, deploy, delete. They will help the user to manage his ui extensions. Prompt and PromptLauncher classes are build on top of python click lib to give the ability to validate and collect the data from the user. Signed-off-by: Nikola Vladimirov Iliev <nvladimirovi@vmware.com>
nvladimirovi
force-pushed
the
extensions
branch
from
9269fa4 to
48e5483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following commads are added: generate, list, deploy, delete.
They will help the user to manage his ui extensions.
CLI Spinner class is implemented to indicate the action of the user.
Extension generator is class which inherits
generator abstract class and
give the ability to copy existing template from
the file system, of the user, and populate it
with the data, given by the user.
Prompt and PromptLauncher classes are
build on top of python click lib to give
the ability to validate and collect
the data from the user.
Signed-off-by: Nikola Vladimirov Iliev nvladimirovi@vmware.com
To help us process your pull request efficiently, please include:
(Required) Short description of changes in the PR topic line
(Required) Detailed description of changes include tests and
documentation. If the pull request contains multiple commits with
detailed messages, refer to those instead
(Optional) Names of reviewers using @ sign + name