Skip to content

fix: use total seconds for registry history - #173

Open
lukekarrys wants to merge 2 commits into
codex/issue-160-outlier-statisticsfrom
codex/issue-154
Open

lukekarrys wants to merge 2 commits into
codex/issue-160-outlier-statisticsfrom
codex/issue-154

Conversation

@lukekarrys

@lukekarrys lukekarrys commented Sep 16, 2026

Copy link
Copy Markdown
Member

Registry history previously selected normalized values such as 60.14 ms/package and displayed them as seconds. It now reads total seconds from registryChartData, matching the existing axis and tooltip labels, and falls back to legacy registry totals in chartData. Dates with only normalized registry data are omitted safely.

The history extraction is isolated for regression tests covering current and legacy payloads, source precedence, missing data, and fixture averaging. The inherited pull-request workflow runs the data tests and app build.

Validation: all 29 combined script/app tests pass, including registry source selection with median and partial-failure metadata. A forced TypeScript build, production app build, and targeted ESLint pass.

Depends on #170 (which depends on #172); all history extraction conflicts are resolved. Median-only history and partial-sample exclusions from the parent PRs are preserved.

Closes #154

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 300c31b0-cf44-4352-84cf-b6c8a243f5f6

📥 Commits

Reviewing files that changed from the base of the PR and between 2a654d4 and 1bcff17.

📒 Files selected for processing (24)
  • .github/workflows/benchmark.yaml
  • .github/workflows/test.yml
  • README.md
  • app/package.json
  • app/src/components/history-chart.tsx
  • app/src/components/ui/chart.tsx
  • app/src/components/variation/chart.tsx
  • app/src/components/variation/index.tsx
  • app/src/components/variation/table.tsx
  • app/src/hooks/use-history-data.ts
  • app/src/lib/history-data.ts
  • app/src/lib/run-completeness.ts
  • app/src/lib/utils.ts
  • app/src/types/chart-data.ts
  • app/tests/partial-results.test.js
  • app/tests/statistics.test.ts
  • scripts/benchmark-data.test.js
  • scripts/benchmark-statistics.js
  • scripts/benchmark-statistics.test.js
  • scripts/clean-benchmarks.js
  • scripts/generate-chart.js
  • scripts/history-data.test.js
  • scripts/partial-results.test.js
  • scripts/process-results.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lukekarrys
lukekarrys changed the base branch from main to codex/issue-160-outlier-statistics September 16, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Use total-time data for the registry history chart’s seconds axis

2 participants