fix: require validated registry lockfile warmups before timing - #171
Open
lukekarrys wants to merge 2 commits into
Open
lukekarrys wants to merge 2 commits into
lukekarrys wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
lukekarrys
had a problem deploying
to
Benchmark
September 16, 2026 00:41 — with
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A timed
registry-lockfilerun could resolve the entire dependency graph when an ignored warmup failure or 300-second timeout left no lockfile. Warmups now run in a checked hyperfine prepare hook, validate a freshly generated npm lockfile for the selected registry, and retain a snapshot checked before every timed run. Failed warmups stop the job, report the phase/exit code in its summary, and preserve diagnostic artifacts.Warmups have a separate 600-second default (
BENCH_WARMUP_TIMEOUT) so observed 300–380-second third-party registry resolution can finish while timed installs retain the 300-second budget. EvenBENCH_WARMUP=0performs the required initial resolution. The README documents this choice and the generated logs.Validation: 11 regression tests pass using real hyperfine, including successful slow warmup, timeout/nonzero exit, missing/invalid/stale/changed lockfiles, and separate npm/vlt warmups through the full variation. A localhost npm registry test verifies both successful timed installs fetch tarballs and no packuments. The existing 5 benchmark-data tests and Bash syntax checks also pass. A dedicated PR workflow runs
scripts/registry/lockfile.test.jswith hyperfine 1.19.0, keeping the native-tool dependency outside the genericscripts/*.test.jsworkflow; full authenticated registry coverage runs in benchmark CI.Closes #159