Centralizes environment variable access by routing variables reads through the envs.py module. #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingliu14
force-pushed
the
env_var
branch
3 times, most recently
from
03b8668 to
2c04b01
Compare
xingliu14
changed the title
Collaborator
|
Is this currently in a review-able state? If not, can you convert it into draft? Also, all the unit tests fails should have been fixed by now, so please try again. |
Collaborator
Author
|
I rebased and verified all unit tests are passed. This is ready for review. |
Collaborator
https://buildkite.com/tpu-commons/tpu-inference-ci/builds/5491 will review it once i'm available. |
kyuyeunk
reviewed
Nov 15, 2025
xingliu14
force-pushed
the
env_var
branch
2 times, most recently
from
15ee8d3 to
b6cfcc4
Compare
Collaborator
|
CI has been fixed. Can you update the branch so I can re-run the ci for this PR? |
Signed-off-by: Xing Liu <xingliu14@gmail.com>
Signed-off-by: Xing Liu <xingliu14@gmail.com>
Signed-off-by: Xing Liu <xingliu14@gmail.com>
Signed-off-by: Xing Liu <xingliu14@gmail.com>
Signed-off-by: Xing Liu <xingliu14@gmail.com>
Signed-off-by: Xing Liu <xingliu14@gmail.com>
Collaborator
Author
|
Done! |
Collaborator
|
Running. Please ping me when the ci finishes!: https://buildkite.com/tpu-commons/tpu-inference-ci/builds/5624 |
kyuyeunk
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Centralizes environment variable access by routing following environment variable reads through the
envs.pymodule.Addressing #1016.
cc @kyuyeunk
Tests
pytest
Checklist
Before submitting this PR, please make sure: