Repository navigation
ci: read the Console client id from a repository variable - #174
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #172. The Console CI token's client id sat in
.github/workflows/ci.ymlas aliteral, and its
sk_+ UUID shape matches GitHub's Checkout.com production-key pattern — sosecret scanning raised a false-positive alert against an older commit of that branch.
OPENCODE_CONSOLE_CLIENT_IDrepository variable. It is anidentifier, not a credential: the exchange binds it to the audience and the GitHub OIDC
subject, and the access token itself is minted per run from the runner's OIDC identity.
test/keyed-probes.test.tsholds the wiring and now fails if the job ever carries ask_-shaped literal again.pnpm run check(0 errors) and the keyed-probes suite pass; the pullrequest's own
e2e · live gatewayrun reads the variable and mints its token.No Checkout.com credential was involved: this repository only uses
actions/checkout, and theflagged value is the id from the Console CI-token setup. The alert is dismissed as a false
positive rather than rotated; the value stays in history as the public identifier it is.