refactor: group worker config metadata - #815
Merged
Merged
Conversation
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
hi-ogawa
marked this pull request as ready for review
September 4, 2026 04:17
sheremet-va
reviewed
Sep 4, 2026
| readonly pkg: VitestPackage, | ||
| readonly projects: SerializedProject[], | ||
| readonly workspaceSource: string | false, | ||
| readonly extensionConfig: ExtensionWorkerConfig, |
Member
There was a problem hiding this comment.
This doesn’t seem like the right name. Extension config is something that configures the extension
Contributor
Author
There was a problem hiding this comment.
Naming is hard. What I ended up is metadata: WorkerReadyMetadata. Now we have to live with meta.metadata in some places.
Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@opencode.ai>
sheremet-va
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This defines a bag of config-related data that is passed from Vitest worker to extension host as
ExtensionWorkerConfig. This would make it simpler for #811 to introduce one more value for html reporter path in the same bag.