Repository navigation
fix(core): start standalone DevTools once for multi-environment builds - #613
Merged
Merged
Conversation
webfansplz
approved these changes
Oct 19, 2026
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
runDevTools()looped over the selected build environments and calledstartDevTools()once per environment, without using the loop variable. Each call starts an identical standalone server for the whole project, sovite buildwithclient+ssrenvironments started two DevTools servers on ports 9999 and 10000.This change starts the standalone server once when at least one selected environment exists. When
environmentsselects none, nothing starts, as before.A new test in
packages/core/src/node/__tests__/integration.test.tsrunsrunDevTools()withclientandssrenvironments and expects onestartDevTools()call. It fails onmain(called 2 times) and passes with this change.Linked Issues
Fixes #612
Additional context
Checked end to end by calling Vite's
createBuilder()andbuildApp()on a project withclientandssrenvironments, thenrunDevTools(builder): the published 0.7.6 build prints two "Vite DevTools started at" lines, the patched build prints one.