fix: prevent memory leak in rate limiter by cleaning up stale IPs#2
Open
Diode11-Alt wants to merge 1 commit intovision-dev1:mainfrom
Open
fix: prevent memory leak in rate limiter by cleaning up stale IPs#2Diode11-Alt wants to merge 1 commit intovision-dev1:mainfrom
Diode11-Alt wants to merge 1 commit intovision-dev1:mainfrom
Conversation
The in-memory rate_limit_storage dict never removes IP keys after they expire. Over time on a busy server this leads to unbounded memory growth. Added a garbage-collection pass that purges inactive IPs once the storage exceeds 10k entries.
Diode11-Alt
commented
Apr 4, 2026
Author
Diode11-Alt
left a comment
Diode11-Alt
left a comment
There was a problem hiding this comment.
Looks good to me! This properly limits the storage mapping sizes and cleans up IPs with no more active timestamps. Excellent memory optimization fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1\n\nThe current
rate_limit_storagedictionary inapp.pystores IP addresses as keys but never removes them after their timestamps expire. This pull request adds a cleanup threshold to prevent an unbounded memory leak.