Register vcell-su download-vcml subcommand and resolve users by id#1675
Open
Register vcell-su download-vcml subcommand and resolve users by id#1675
Conversation
DatabaseCommand existed but was never wired into the AdminCLI subcommand list, so 'vcell-su download-vcml' was unreachable. Register it. Add a --userid option that resolves the User key via AdminDBTopLevel, so admins can fetch private biomodels by username alone instead of needing the userid:userkey pair. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatabaseCommand(thedownload-vcmladmin subcommand for fetching cached VCML directly from the database) existed invcell-admin/.../tools/DatabaseCommand.javabut was never wired into theAdminCLIsubcommand list, sovcell-su download-vcmlwas unreachable. This adds it.--userid <name>option that resolves the User key viaAdminDBTopLevel.getUser(...), so admins can fetch private biomodels by username alone instead of needing theuserid:userkeypair. The existing--user userid:keyoption still works.Why
Used during investigation of two biomodels failing to load from the primary Oracle DB. The existing tooling required the user-key (a numeric internal id), which we don't have for arbitrary users. With
--userid, an admin can fetch any private biomodel by--biomodel-id <id> --userid <name>.Test plan
mvn -pl vcell-admin -am compile -DskipTestscleanvcell-su -hlistsdownload-vcmlas a subcommandvcell-su download-vcml --biomodel-id=<id> --userid=<name> -o <dir> --regenerateXML=false --publishedOnly=falseretrieves the cached VCML for a private biomodel--user userid:keyform still works (regression check)🤖 Generated with Claude Code