chore: consolidate open dependency updates - #392
Merged
Conversation
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.16.1 to 0.16.2. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.16.1...0.16.2) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.16.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [starlette](https://github.com/Kludex/starlette) from 1.3.1 to 1.6.0. - [Release notes](https://github.com/Kludex/starlette/releases) - [Changelog](https://github.com/Kludex/starlette/blob/main/docs/release-notes.md) - [Commits](Kludex/starlette@1.3.1...1.6.0) --- updated-dependencies: - dependency-name: starlette dependency-version: 1.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [coverage](https://github.com/coveragepy/coveragepy) from 7.15.3 to 7.15.4. - [Release notes](https://github.com/coveragepy/coveragepy/releases) - [Changelog](https://github.com/coveragepy/coveragepy/blob/main/CHANGES.rst) - [Commits](coveragepy/coveragepy@7.15.3...7.15.4) --- updated-dependencies: - dependency-name: coverage dependency-version: 7.15.4 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sphinx-autodoc-typehints](https://github.com/tox-dev/sphinx-autodoc-typehints) from 3.13.0 to 3.13.2. - [Release notes](https://github.com/tox-dev/sphinx-autodoc-typehints/releases) - [Commits](tox-dev/sphinx-autodoc-typehints@3.13.0...3.13.2) --- updated-dependencies: - dependency-name: sphinx-autodoc-typehints dependency-version: 3.13.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.5.7 to 6.5.8. - [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst) - [Commits](tornadoweb/tornado@v6.5.7...v6.5.8) --- updated-dependencies: - dependency-name: tornado dependency-version: 6.5.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github/codeql-action/autobuild](https://github.com/github/codeql-action) from 4.37.5 to 4.37.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@d1ba80a...5595cca) --- updated-dependencies: - dependency-name: github/codeql-action/autobuild dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github/codeql-action/init](https://github.com/github/codeql-action) from 4.37.5 to 4.37.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@d1ba80a...5595cca) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github/codeql-action/analyze](https://github.com/github/codeql-action) from 4.37.5 to 4.37.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@d1ba80a...5595cca) --- updated-dependencies: - dependency-name: github/codeql-action/analyze dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…/codeql-action/analyze-4.37.6' into agent/consolidate-open-prs-384-391
…/codeql-action/init-4.37.6' into agent/consolidate-open-prs-384-391
…/codeql-action/autobuild-4.37.6' into agent/consolidate-open-prs-384-391
…8' into agent/consolidate-open-prs-384-391
…oc-typehints-3.13.2' into agent/consolidate-open-prs-384-391
…into agent/consolidate-open-prs-384-391
…6.0' into agent/consolidate-open-prs-384-391
… agent/consolidate-open-prs-384-391 # Conflicts: # requirements-dev.in
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideConsolidates eight dependency-update PRs into a single branch by aligning CodeQL GitHub Actions on v4.37.6 and updating documentation and development Python dependencies, while preserving the original commits from the superseded PRs. Sequence diagram for unified CodeQL GitHub Actions workflowsequenceDiagram
participant workflow
participant codeql_init
participant codeql_autobuild
participant codeql_analyze
workflow->>codeql_init: github/codeql-action/init@v4.37.6
codeql_init-->>workflow: initialize CodeQL with matrix.language
workflow->>codeql_autobuild: github/codeql-action/autobuild@v4.37.6
codeql_autobuild-->>workflow: build project for analysis
workflow->>codeql_analyze: github/codeql-action/analyze@v4.37.6
codeql_analyze-->>workflow: perform CodeQL analysis
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1037 1037
=========================================
Hits 1037 1037
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since all three CodeQL steps now use the same pinned SHA, consider factoring the version/sha into a single workflow variable or reusable workflow to avoid having to update multiple entries on future upgrades.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since all three CodeQL steps now use the same pinned SHA, consider factoring the version/sha into a single workflow variable or reusable workflow to avoid having to update multiple entries on future upgrades.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates all eight open dependency-update PRs into one branch based on the latest
master.init,autobuild, andanalyzeon v4.37.6 and the same immutable SHAWhy
The three individual CodeQL PRs run mixed CodeQL action versions and fail the analysis job independently. Combining them applies the coordinated upgrade atomically. The remaining updates are compatible patch/minor dependency changes.
Validation
make lintmake test— 420 passed, 102 skipped, 100% coverageuv run --locked --extra dev --with ty ty check --python .venv json2xml testslat checkSummary by Sourcery
Consolidate dependency and CodeQL workflow updates into a single branch based on the latest master.
Enhancements:
CI:
Documentation:
Chores: