Fix CI/CD pipeline with deploy job#35
Merged
vimal-java-dev merged 1 commit intovimal-java-dev:mainfrom Apr 5, 2026
Merged
Conversation
Signed-off-by: vimal-tech-dev <be08it929@gmail.com>
vimal-java-dev
added
enhancement
vimal-java-dev
approved these changes
Apr 5, 2026
| - name: Push Docker image | ||
| run: | | ||
| docker push ghcr.io/vimal-java-dev/vimaltech-contact-api:latest No newline at end of file | ||
| docker push ghcr.io/vimal-java-dev/vimaltech-contact-api:latest |
Owner
There was a problem hiding this comment.
Good for auto-deploy to VPS
✅ 3. Proper Dependency Chain
deploy → needs: docker
docker → needs: build
Because,
👉 Guarantees:
- No deploy if build fails
- No deploy if image push fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment added with this condition in the yml file,
deploy:
# ✅ CRITICAL CONDITION (owner repo only)
if: github.event_name == 'push' && github.repository == 'vimal-java-dev/vimaltech-contact-api'
needs: docker
runs-on: ubuntu-latest