-
Notifications
You must be signed in to change notification settings - Fork 434
chore: get ci passing and update node #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
==========================================
+ Coverage 84.00% 84.04% +0.03%
==========================================
Files 44 44
Lines 11713 11713
Branches 2625 2625
==========================================
+ Hits 9840 9844 +4
+ Misses 1873 1869 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // pin Browserstack Firefox version to 64 | ||
| if (defaults.bsFirefox) { | ||
| // eslint-disable-next-line camelcase | ||
| defaults.bsFirefox.browser_version = '64.0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this firefox is pretty old at this point (current is 147), even older than firefox ESR (their LTS release). Would be nice to update, but not a blocker for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I see the comment about firefox. Theoretically, a karma bump should fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried going to latest Karma and unpinning but immediately got failures in CI so reverted. We might want to look into an alternative to Karma at some point, depending on how active (or not) VHS maintenance requirements are in a world with VJS10 in it. I've had good results wrapping existing QUnit test suites with Playwright and headless chromium, ff &. webkit. That doesn't solve everything but might be a good fit for VHS because it doesn't run anything in Safari.
d2c6c8a to
b2f8e06
Compare
c7b5822 to
7605010
Compare
It seems ci test runs have been failing for a while and after a bit of investigation there seem to be two main culprits:
For good measure, I've also updated Node to v22.