Skip to content

Conversation

@Essk
Copy link
Contributor

@Essk Essk commented Jul 23, 2025

It seems ci test runs have been failing for a while and after a bit of investigation there seem to be two main culprits:

  1. We need to pin Firefox to v64, same as for VJS
  2. Looks like there may be a regression in playback for the source used for "DRM Dash" playback test. This asset plays in the DASH reference player but not the VHS demo.
  • We recently improved support for multi-DRM in contrib-eme, so I've bumped to the latest version but sadly this doesn't seem to fix things for this asset. Further investigation will be needed.

For good measure, I've also updated Node to v22.

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.04%. Comparing base (0dfc165) to head (7605010).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
+ Coverage   84.00%   84.04%   +0.03%     
==========================================
  Files          44       44              
  Lines       11713    11713              
  Branches     2625     2625              
==========================================
+ Hits         9840     9844       +4     
+ Misses       1873     1869       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Essk Essk changed the title chore: update to node 22 chore: get ci passing and update node Jul 23, 2025
@Essk Essk marked this pull request as ready for review July 23, 2025 12:43
// pin Browserstack Firefox version to 64
if (defaults.bsFirefox) {
// eslint-disable-next-line camelcase
defaults.bsFirefox.browser_version = '64.0';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this firefox is pretty old at this point (current is 147), even older than firefox ESR (their LTS release). Would be nice to update, but not a blocker for this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see the comment about firefox. Theoretically, a karma bump should fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried going to latest Karma and unpinning but immediately got failures in CI so reverted. We might want to look into an alternative to Karma at some point, depending on how active (or not) VHS maintenance requirements are in a world with VJS10 in it. I've had good results wrapping existing QUnit test suites with Playwright and headless chromium, ff &. webkit. That doesn't solve everything but might be a good fit for VHS because it doesn't run anything in Safari.

@Essk Essk force-pushed the chore/update-node-22 branch from d2c6c8a to b2f8e06 Compare January 22, 2026 15:16
@Essk Essk force-pushed the chore/update-node-22 branch 3 times, most recently from c7b5822 to 7605010 Compare January 22, 2026 17:18
@Essk Essk merged commit 8833e33 into main Jan 22, 2026
27 checks passed
@Essk Essk deleted the chore/update-node-22 branch January 22, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants