Repository navigation
fix: read Java version from maven-compiler-plugin configuration - #679
Open
vibgrate-team wants to merge 1 commit into
Open
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
parsePom only read java.version and maven.compiler.* properties, so a POM
that set the language level on maven-compiler-plugin reported no Java
runtime. When those properties are absent, read the plugin's release, then
source, then target, from build.plugins and build.pluginManagement, and
resolve ${property} references.
Signed-off-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: ABIZ - Agentic Business Record Standard <ops@to.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reads the Java version from
maven-compiler-pluginconfiguration when no Java version property is set in<properties>.What changed
parsePomstill checks<properties>first (java.version,maven.compiler.source,maven.compiler.target,maven.compiler.release,java.source.version).maven-compiler-pluginunderbuild.pluginsandbuild.pluginManagement(single plugin or array, matched byartifactId) and reads<release>, then<source>, then<target>.resolveProperty; anything still containing${is ignored.Tests
test/maven-compiler-java-version.test.tscovers<release>17</release>,<source>11</source>fallback, amaven.compiler.releaseproperty still winning,${jdk.version}resolution,<target>, both plugin locations as object and array, and an unresolved placeholder.pnpm test,pnpm typecheckandpnpm lintpass.Closes #658