Skip to content

Auto-label dependabot and viam-overwatch PRs safe to test - #909

Merged
Ale Paredes (ale7714) merged 1 commit into
mainfrom
fix/pr-labeler-trust-dependabot-overwatch
Sep 24, 2026
Merged

Ale Paredes (ale7714) merged 1 commit into
mainfrom
fix/pr-labeler-trust-dependabot-overwatch

Conversation

@ale7714

Copy link
Copy Markdown
Member

Dependabot and viam-overwatch push same-repo branches but are not org members. The membership call throws for a non-member, so the labeler step failed on every bot push and someone added safe to test by hand (see #884). The script now mirrors rdk's labeler: a trusted-bot list for same-repo heads, a fail-closed membership check, and a non-fatal label removal.

The label is applied with the org PR_TOKEN instead of GITHUB_TOKEN. A label added with GITHUB_TOKEN does not fire the labeled trigger in pullrequest.yml, so a bot PR would sit labeled but untested until its next push. rdk, goutils, docs and slam-cloud-session already label with PR_TOKEN.

A fork PR never takes the bot path, so a bot login cannot skip the membership check from outside. Same shape as viamrobotics/rdk#6536.

🤖 Generated with Claude Code

Both bots push same-repo branches but are not org members, so the membership call threw for them, the step failed, and someone had to add the label by hand. The label is applied with PR_TOKEN because a GITHUB_TOKEN label event does not start pullrequest.yml, so a labeled bot PR would otherwise not test until its next push. The bot path never applies to fork heads, so a fork cannot use a bot login to skip the check.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added the safe to test committer is a member of this org label Sep 24, 2026
@ale7714 Ale Paredes (ale7714) added the ready-for-protos add this when you want protos to compile on every commit label Sep 24, 2026
@ale7714 Ale Paredes (ale7714) removed the ready-for-protos add this when you want protos to compile on every commit label Sep 24, 2026
@ale7714
Ale Paredes (ale7714) merged commit 653c0a2 into main Sep 24, 2026
9 of 10 checks passed
@ale7714
Ale Paredes (ale7714) deleted the fix/pr-labeler-trust-dependabot-overwatch branch September 24, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

protos-compiled safe to test committer is a member of this org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant