feat(plugin): add Lua file and directory operations#677
Open
HowXu wants to merge 3 commits into
Open
Conversation
Member
|
推荐改名叫 fs |
Author
quite good, i'll do it later |
Member
|
@aooohan 我看之前就有这个 file 的 lua preload,这个是已经在线上在用的吗 |
Author
symlink是自带在file.go里的,我给它扩展的copy/move功能本来也是写在file.go里的。 出于兼容性考虑我觉得其实改名fs也不太好(尤其是突然看到说file其实有在用),单独拿出来写成一个module略显多余。而且如果file.go的功能有symlink,那把copy/move写在里面也是合理的。 或者额外写一个module,但是那就不能叫fs了我觉得,命令的话我觉得file还是最合适的,因为确实是对file的操作。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy,remove,moveAPIs to Lua pluginsfilemodule in plugin VMsTests
Closes #671