fix(security): 2 improvements across 2 files#662
Open
tomaioo wants to merge 2 commits intoversion-fox:mainfrom
Open
fix(security): 2 improvements across 2 files#662tomaioo wants to merge 2 commits intoversion-fox:mainfrom
tomaioo wants to merge 2 commits intoversion-fox:mainfrom
Conversation
- Security: Command injection risk when exporting PATH in Zsh activation script - Security: Windows shell export does not escape values before emitting `set` commands Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Command injection risk when exporting PATH in Zsh activation script - Security: Windows shell export does not escape values before emitting `set` commands Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:internal/shell/zsh.go:L78The
zsh.exportmethod special-casesPATHand interpolates it directly into a double-quoted shell assignment (export PATH="%s";) without escaping. If a PATH segment contains shell metacharacters or command substitution syntax (e.g.,$(...)or backticks), it can be evaluated when the activation script is sourced, leading to code execution in the user shell context.Solution
Apply the same escaping logic used for other variables to PATH values (or use a robust shell-quoting helper for all vars). Avoid raw interpolation into double quotes.
Changes
internal/shell/zsh.go(modified)internal/shell/clink.go(modified)