Skip to content

Fix trailing slash in VFOX_NODEJS_MIRROR causing double slashes in URL paths #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bytemain merged 2 commits into from
Dec 17, 2025
Merged

Fix trailing slash in VFOX_NODEJS_MIRROR causing double slashes in URL paths #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d5f543
Initial plan
Copilot Dec 17, 2025
dbad242
Fix trailing slash issue in VFOX_NODEJS_MIRROR URL handling
Copilot Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ vfox add nodejs
## Mirror

You can configure the mirror by `VFOX_NODEJS_MIRROR` environment variable. The default value
is `https://nodejs.org/dist/`.
is `https://nodejs.org/dist`. Trailing slashes are automatically handled, so both
`https://nodejs.org/dist` and `https://nodejs.org/dist/` will work correctly.
3 changes: 2 additions & 1 deletion lib/util.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ function UTIL.getBaseUrl()
if mirror == "" or mirror == nil then
return "https://nodejs.org/dist"
end
return mirror
-- Strip trailing slash to avoid double slashes in URL paths
return mirror:gsub("/$", "")
end

function UTIL.compare_versions(v1o, v2o)
Expand Down