-
Notifications
You must be signed in to change notification settings - Fork 430
[Spelling] Fixed Spelling in Documentation #3353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spelling] Fixed Spelling in Documentation #3353
Conversation
Used codespell to fix all of the spelling in the documentation. This is basically all files which are not in the vpr or libs folder.
|
@vaughnbetz FYI. I am actually surprised how few spelling mistakes there were in the documentation. 174 lines is not bad. VPR and libs is much worse at around 600. That's coming in later. |
AmirhosseinPoolad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There's some stuff here that you could do here, do in a later PR or even just raise an issue on.
| code then run some regression tests. Buildbot flags problems and reports who | ||
| made which commit. The VTR buildbot website is located here: | ||
| http://canucks.eecg.toronto.edu:8080/ It gives you regular updates on the state | ||
| of thet trunk. As the administrator, you should check buildbot regularly (eg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this entire folder? The information is quite outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not using buildbot anymore, so we should remove outdated info (maybe all is outdated here).
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/env bash | |||
| #Reformats and then ammends the currently checked-out commit | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably also rename the file itself. Or maybe delete it, I don't think it's used by anyone.
| #!/usr/bin/env bash | ||
|
|
||
| #Reformat and ammend each commit since the provided | ||
| #Reformat and amend each commit since the provided |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this file, I think we might as well just remove it.
|
@AmirhosseinPoolad Thanks for the review! I agree with your points, but it should not block this PR. See #3354 I will merge. |
Used codespell to fix all of the spelling in the documentation. This is basically all files which are not in the vpr or libs folder.