Skip to content

Conversation

@AlexandreSinger
Copy link
Contributor

Used codespell to fix all of the spelling in the documentation. This is basically all files which are not in the vpr or libs folder.

Used codespell to fix all of the spelling in the documentation. This is
basically all files which are not in the vpr or libs folder.
@github-actions github-actions bot added docs Documentation lang-cpp C/C++ code build Build system scripts Utility & Infrastructure scripts lang-python Python code lang-make CMake/Make code tests lang-shell Shell scripts (bash etc.) labels Nov 20, 2025
@AlexandreSinger
Copy link
Contributor Author

@vaughnbetz FYI. I am actually surprised how few spelling mistakes there were in the documentation. 174 lines is not bad. VPR and libs is much worse at around 600. That's coming in later.

Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's some stuff here that you could do here, do in a later PR or even just raise an issue on.

code then run some regression tests. Buildbot flags problems and reports who
made which commit. The VTR buildbot website is located here:
http://canucks.eecg.toronto.edu:8080/ It gives you regular updates on the state
of thet trunk. As the administrator, you should check buildbot regularly (eg.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this entire folder? The information is quite outdated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using buildbot anymore, so we should remove outdated info (maybe all is outdated here).

@@ -1,5 +1,5 @@
#!/usr/bin/env bash
#Reformats and then ammends the currently checked-out commit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably also rename the file itself. Or maybe delete it, I don't think it's used by anyone.

#!/usr/bin/env bash

#Reformat and ammend each commit since the provided
#Reformat and amend each commit since the provided
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this file, I think we might as well just remove it.

@AlexandreSinger
Copy link
Contributor Author

@AmirhosseinPoolad Thanks for the review! I agree with your points, but it should not block this PR. See #3354

I will merge.

@AlexandreSinger AlexandreSinger merged commit 17b226d into verilog-to-routing:master Nov 21, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system docs Documentation lang-cpp C/C++ code lang-make CMake/Make code lang-python Python code lang-shell Shell scripts (bash etc.) scripts Utility & Infrastructure scripts tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants