Skip to content

Fix build error with LLVM 21 due to operator function redefinition #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+8 −14
Closed

Fix build error with LLVM 21 due to operator function redefinition #3349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da155f
Change signature of StrongIdIterator operators to ensure each instant…
heshpdx Nov 20, 2025
04c0b28
Fix type name
heshpdx Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions libs/libvtrutil/src/vtr_strong_id_range.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,7 @@ class StrongIdIterator {
}

///@brief ~ operator
template<typename IdType>
ssize_t operator-(const StrongIdIterator<IdType>& other) const {
ssize_t operator-(const StrongIdIterator<StrongId>& other) const {
VTR_ASSERT_SAFE(bool(id_));
VTR_ASSERT_SAFE(bool(other.id_));

Expand All @@ -107,20 +106,17 @@ class StrongIdIterator {
}

///@brief == operator
template<typename IdType>
bool operator==(const StrongIdIterator<IdType>& other) const {
bool operator==(const StrongIdIterator<StrongId>& other) const {
return id_ == other.id_;
}

///@brief != operator
template<typename IdType>
bool operator!=(const StrongIdIterator<IdType>& other) const {
bool operator!=(const StrongIdIterator<StrongId>& other) const {
return id_ != other.id_;
}

///@brief < operator
template<typename IdType>
bool operator<(const StrongIdIterator<IdType>& other) const {
bool operator<(const StrongIdIterator<StrongId>& other) const {
return id_ < other.id_;
}

Expand All @@ -129,19 +125,17 @@ class StrongIdIterator {
};

///@brief + operator
template<typename IdType>
inline StrongIdIterator<IdType> operator+(
const StrongIdIterator<IdType>& lhs,
inline StrongIdIterator<StrongId> operator+(
const StrongIdIterator<StrongId>& lhs,
ssize_t n) {
StrongIdIterator ret = lhs;
ret += n;
return ret;
}

///@brief - operator
template<typename IdType>
inline StrongIdIterator<IdType> operator-(
const StrongIdIterator<IdType>& lhs,
inline StrongIdIterator<StrongId> operator-(
const StrongIdIterator<StrongId>& lhs,
ssize_t n) {
StrongIdIterator ret = lhs;
ret -= n;
Expand Down
Loading