Reorganize place timing files #2829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neighboring_average
github-actions
bot
added
VPR
github-actions
bot
added
the
libarchfpga
it doesn't compile
Contributor
AlexandreSinger
left a comment
AlexandreSinger
left a comment
There was a problem hiding this comment.
LGTM. Just some minor comments.
vaughnbetz
requested changes
Dec 16, 2024
Contributor
vaughnbetz
left a comment
vaughnbetz
left a comment
There was a problem hiding this comment.
Looks generally good. A few suggestions on commenting.
Also, src/place/timing/delay/.cpp seems like an excessively long path name.
I suggest src/place/delay/.cpp instead; there's no real reason delay has to go under timing, and I think code is harder to discovery when the directory hierarchy gets too deep.
…defining them multiple times
Contributor
Author
|
regression_tests/vtr_reg_nightly_test3/vtr_reg_qor_chain_large
|
soheilshahrouz
changed the title
Contributor
|
Looks like NO_GRAPHICS has a compile error. Otherwise good to merge once that is fixed. |
Contributor
Author
|
@vaughnbetz |
Contributor
|
Will merge once CI finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vpr/src/placedirectory has too many files, making it difficult to locate related files. This PR organizes timing related files and classes under a new directoryvpr/src/place/timing.place/timing/delay_model.timing_place.cpp/.hand created seperate files forPlacerCriticalities,PlacerSetupSlacks, andPlacerTimingCosts.physical_types_util.cppare now implemented as member functions of structs declared inphysical_types.h.